From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:59901) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3hZK-0002C9-1a for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:08:38 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V3hZE-0004ta-Kg for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:08:33 -0400 Received: from mx1.redhat.com ([209.132.183.28]:11953) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V3hZE-0004tO-BH for qemu-devel@nongnu.org; Mon, 29 Jul 2013 03:08:28 -0400 Date: Mon, 29 Jul 2013 10:09:48 +0300 From: "Michael S. Tsirkin" Message-ID: <20130729070948.GB2308@redhat.com> References: <87li4v8ktz.fsf@rustcorp.com.au> <87ehan8hhn.fsf@rustcorp.com.au> <87ppu66a73.fsf@codemonkey.ws> <20130725145215.GA3758@redhat.com> <51F13C85.8050108@suse.de> <20130725152427.GH3758@redhat.com> <87iozybonc.fsf@codemonkey.ws> <8738qy8ck7.fsf@rustcorp.com.au> MIME-Version: 1.0 Content-Type: text/plain; charset=iso-8859-1 Content-Disposition: inline In-Reply-To: <8738qy8ck7.fsf@rustcorp.com.au> Content-Transfer-Encoding: quoted-printable Subject: Re: [Qemu-devel] vhost acceleration broken? List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Rusty Russell Cc: Peter Maydell , Stefan Hajnoczi , Andreas =?iso-8859-1?Q?F=E4rber?= , Anthony Liguori , qemu-devel On Mon, Jul 29, 2013 at 09:25:20AM +0930, Rusty Russell wrote: > Anthony Liguori writes: > > "Michael S. Tsirkin" writes: > > > >> On Thu, Jul 25, 2013 at 04:56:05PM +0200, Andreas F=E4rber wrote: > >>> Am 25.07.2013 16:52, schrieb Michael S. Tsirkin: > >>> > On Thu, Jul 25, 2013 at 08:28:00AM -0500, Anthony Liguori wrote: > >>> >> We have a pretty awful legacy command line set that comes from y= ears of > >>> >> half-baked concepts and the years when too many people just comm= itted > >>> >> random shit to the tree. > >>> >> > >>> >> I think we probably need to start planning for a clean break. M= aybe > >>> >> that's a good target for a 2.0 version... > >>> >=20 > >>> > Assuming -netdev supports all required configurations, we should > >>> > remove -net from the -help output. > >>>=20 > >>> Peter had raised the issue of -netdev not working well with boards = that > >>> already supply a default NIC - was there a solution yet? > >>>=20 > >>> Andreas > >> > >> Whoever is removing -net will have to code that up. Want to do this? > > > > I would not rush to remove things. If we're going to go through a > > deprecation process, we should start with a proposal on what things > > should be removed and go from there. > > > > I still don't even think -netdev is the right answer here either. > > Wouldn't it make more sense to have something like: > > > > qemu -vnic tap,script=3D/foo/myscript > > > > Or something vaguely understandable by a human? >=20 > OK. It seems to me that each net device has a host side and a guest > side, which you can mix and match. So the commandline should reflect > that explicitly: >=20 > qemu -hostdev net,[tap|user|bridge|socket|vde],.... -guestdev = net,.... >=20 > If you have a built-in net device on your emulated board, you've got on= e > implied -guestdev net. And similar principles apply to other things > like consoles and disks. I think what Peter was asking for is a way to set parameters on the implied -guestdev (we use -netdev for this). > Now, guest and host terms may suck. But please pick one terminology an= d > use it *everywhere*. Documentation, code and cmdline. >=20 > Thanks, > Rusty.