All of lore.kernel.org
 help / color / mirror / Atom feed
From: Albert ARIBAUD <albert.u.boot@aribaud.net>
To: u-boot@lists.denx.de
Subject: [U-Boot] [PATCH 1/9] arm926ej-s: Invalidate instruction cache in flush_cache
Date: Mon, 29 Jul 2013 16:09:21 +0200	[thread overview]
Message-ID: <20130729160921.06b22cb2@lilith> (raw)
In-Reply-To: <CABj7ZYi9FYACzeYW=WRSnAtMOxu=JMNEtjkr-i5ZDC2fpyib0g@mail.gmail.com>

Hi Michael,

On Mon, 29 Jul 2013 08:57:53 -0400, Michael Spang
<mspang@csclub.uwaterloo.ca> wrote:

> Albert,
> 
> That's not a correct characterization of the bug.
> 
> The incoherent cache lines are from before the relocation stage. If
> U-Boot is relocating from RAM, and later copies the OS there without
> invalidating those lines, then that's a bug in U-Boot.

Thanks for this pointing out this scenario, which is correct, although
it was not raised in the original bug description.

I begs however the question whether anything from re-relocation can
survive in the icache from between the moment the relocation starts and
the moment the OS is given transfer to. IOW, was this issue actually
met?

Anyway I stand by my statement that even if there is an issue to fix,
this patch fixes it in the wrong place.

> Michael

Amicalement,
-- 
Albert.

  reply	other threads:[~2013-07-29 14:09 UTC|newest]

Thread overview: 45+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2011-03-17 19:46 [U-Boot] [PATCH 0/9] TS-7800 port for U-Boot Michael Spang
2011-03-17 19:46 ` [U-Boot] [PATCH 1/9] arm926ej-s: Invalidate instruction cache in flush_cache Michael Spang
2011-03-20  2:30   ` arden jay
2011-03-20  3:44     ` Michael Spang
2011-03-20  5:36       ` arden jay
2011-03-20  8:18         ` Albert ARIBAUD
2011-03-20 14:14           ` arden jay
2011-03-20 18:26         ` Michael Spang
2011-03-21  5:44     ` Aneesh V
2011-03-21 14:14       ` arden jay
2013-07-29  7:19   ` Albert ARIBAUD
2013-07-29 12:57     ` Michael Spang
2013-07-29 14:09       ` Albert ARIBAUD [this message]
2013-07-29 14:22         ` Michael Spang
2011-03-17 19:46 ` [U-Boot] [PATCH 2/9] mvgbe: Support preserving the existing MAC address Michael Spang
2011-04-24 23:50   ` Wolfgang Denk
2011-04-25 11:37     ` Tabi Timur-B04825
2011-04-26  4:23       ` Michael Spang
2011-04-30  4:17         ` Mike Frysinger
2011-04-30 14:34           ` Tabi Timur-B04825
2011-05-01  5:40             ` Mike Frysinger
2011-04-26  4:20     ` Michael Spang
2011-04-30  4:21   ` Mike Frysinger
2011-03-17 19:46 ` [U-Boot] [PATCH 3/9] orion5x: Increase maximum bank size to 128M Michael Spang
2011-03-17 19:46 ` [U-Boot] [PATCH 4/9] orion5x: Fix wrong address in orion5x_sdram_bar Michael Spang
2011-03-17 19:46 ` [U-Boot] [PATCH 5/9] ARM: Rename CONFIG_SKIP_LOWLEVEL_INIT to CONFIG_SKIP_CPU_INIT_CRIT Michael Spang
2011-04-24 23:53   ` Wolfgang Denk
2011-04-26  3:44     ` Michael Spang
2011-03-17 19:47 ` [U-Boot] [PATCH 6/9] ARM: Implement CONFIG_SKIP_LOWLEVEL_INIT for arm926ej-s Michael Spang
2011-04-24 23:55   ` Wolfgang Denk
2011-04-25  7:30     ` Albert ARIBAUD
2011-04-26  4:44     ` Michael Spang
2011-03-17 19:47 ` [U-Boot] [PATCH 7/9] Add board support for TS-7800 Michael Spang
2011-04-24 23:57   ` Wolfgang Denk
2011-04-26  3:38     ` Michael Spang
2011-03-17 19:47 ` [U-Boot] [PATCH 8/9] Add NAND " Michael Spang
2011-03-17 20:22   ` Scott Wood
2011-04-24 23:59   ` Wolfgang Denk
2011-04-26  4:01     ` Michael Spang
2011-04-26  4:27       ` Wolfgang Denk
2011-03-17 19:47 ` [U-Boot] [PATCH 9/9] Add README " Michael Spang
2011-04-25  0:01   ` Wolfgang Denk
2011-04-26  4:03     ` Michael Spang
2011-03-17 19:53 ` [U-Boot] [PATCH 0/9] TS-7800 port for U-Boot Michael Spang
2011-03-17 20:01 ` Albert ARIBAUD

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130729160921.06b22cb2@lilith \
    --to=albert.u.boot@aribaud.net \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.