From: Luiz Capitulino <lcapitulino@redhat.com>
To: "Andreas Färber" <afaerber@suse.de>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>,
lersek@redhat.com, qemu-devel@nongnu.org,
tomoki.sekiyama@hds.com
Subject: Re: [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp
Date: Mon, 29 Jul 2013 17:20:18 -0400 [thread overview]
Message-ID: <20130729172018.302018df@redhat.com> (raw)
In-Reply-To: <51EDA2D1.5080603@suse.de>
On Mon, 22 Jul 2013 23:23:29 +0200
Andreas Färber <afaerber@suse.de> wrote:
> Am 22.07.2013 23:03, schrieb Seiji Aguchi:
> > Convert stderr messages calling error_get_pretty()
> > to error_report().
> >
> > Timestamp is prepended by -msg timstamp option with it.
> >
> > This is suggested by Luiz Capitulino.
> >
> > http://marc.info/?l=qemu-devel&m=137331442628866&w=2
> >
> > Signed-off-by: Seiji Aguchi <seiji.aguchi@hds.com>
> > ---
> > arch_init.c | 4 ++--
> > hw/char/serial.c | 5 +++--
> > hw/i386/pc.c | 6 +++---
> > qemu-char.c | 2 +-
> > target-i386/cpu.c | 2 +-
> > target-ppc/translate_init.c | 3 ++-
> > vl.c | 9 +++++----
> > 7 files changed, 17 insertions(+), 14 deletions(-)
>
> How is this related to error_get_pretty()?
Yeah, we're converting fprintf(stderr,) calls to error_report() so that
error messages get a timestamp.
> And does error_report() expect a trailing \n or not? I would assume no,
> but spotted some in this patch.
Yes, already confirmed by Markus.
next prev parent reply other threads:[~2013-07-29 21:20 UTC|newest]
Thread overview: 9+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 21:03 [Qemu-devel] [PATCH] Convert stderr message calling error_get_pretty() to error_report() to prepend timestamp Seiji Aguchi
2013-07-22 21:23 ` Andreas Färber
2013-07-23 6:47 ` Markus Armbruster
2013-07-29 21:20 ` Luiz Capitulino [this message]
2013-07-29 21:23 ` Andreas Färber
2013-07-29 21:45 ` Luiz Capitulino
2013-07-30 0:00 ` Markus Armbruster
2013-07-30 0:34 ` Luiz Capitulino
2013-07-30 1:22 ` Seiji Aguchi
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729172018.302018df@redhat.com \
--to=lcapitulino@redhat.com \
--cc=afaerber@suse.de \
--cc=lersek@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=seiji.aguchi@hds.com \
--cc=tomoki.sekiyama@hds.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.