From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:38582)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3vGO-0005hy-VW
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 17:46:02 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3vGK-0007ll-M7
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 17:45:56 -0400
Received: from mx1.redhat.com ([209.132.183.28]:40605)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3vGK-0007kw-Ei
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 17:45:52 -0400
Date: Mon, 29 Jul 2013 17:45:44 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130729174544.104eecd0@redhat.com>
In-Reply-To: <51F6DD54.2060503@suse.de>
References: <51ED9E3F.3080504@hds.com> <51EDA2D1.5080603@suse.de>
	<20130729172018.302018df@redhat.com> <51F6DD54.2060503@suse.de>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Convert stderr message calling
 error_get_pretty() to error_report() to prepend timestamp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>, lersek@redhat.com, qemu-devel@nongnu.org, tomoki.sekiyama@hds.com

On Mon, 29 Jul 2013 23:23:32 +0200
Andreas F=C3=A4rber <afaerber@suse.de> wrote:

> Am 29.07.2013 23:20, schrieb Luiz Capitulino:
> > On Mon, 22 Jul 2013 23:23:29 +0200
> > Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> >> Am 22.07.2013 23:03, schrieb Seiji Aguchi:
> >>> Convert stderr messages calling error_get_pretty()
> >>> to error_report().
> >>
> >> How is this related to error_get_pretty()?
> >=20
> > Yeah, we're converting fprintf(stderr,) calls to error_report() so that
> > error messages get a timestamp.
>=20
> Want to add that to my http://wiki.qemu.org/DeveloperNews so that people
> reading it stop adding new ones? :)

Big IMHO here, but honestly speaking I'm not a huge fan of error_report()
because I think that random code shouldn't be allowed to print to the
monitor (only HMP code should).

But it's widespread and it's where the timestamp lives, so calling fprintf()
instead of error_report() will probably start hurting soon.