All of lore.kernel.org
 help / color / mirror / Atom feed
From: Konrad Rzeszutek Wilk <konrad.wilk@oracle.com>
To: Ian Campbell <Ian.Campbell@citrix.com>
Cc: julien.grall@citrix.com, xen-devel@lists.xen.org, tim@xen.org,
	Stefano Stabellini <stefano.stabellini@eu.citrix.com>
Subject: Re: [PATCH] xen: arm: document which hypercalls (and subops) are supported on ARM
Date: Mon, 29 Jul 2013 14:09:29 -0400	[thread overview]
Message-ID: <20130729180929.GA13280@phenom.dumpdata.com> (raw)
In-Reply-To: <1375109811.12741.21.camel@kazak.uk.xensource.com>

On Mon, Jul 29, 2013 at 03:56:51PM +0100, Ian Campbell wrote:
> On Tue, 2013-07-23 at 17:59 +0100, Ian Campbell wrote:
> > On Tue, 2013-07-23 at 16:34 +0100, Stefano Stabellini wrote:
> > > On Tue, 23 Jul 2013, Ian Campbell wrote:
> > > > On Tue, 2013-07-23 at 12:33 +0100, Stefano Stabellini wrote:
> > > > 
> > > > > You are missing all the common tmem ops.
> > > > 
> > > > tmem_ops are not hooked up in arm_hypercall_table, so they are currently
> > > > not supported. We should add them here when we add the necessary
> > > > support. ISTR stubbing out some functions which are used by tmem
> > > > (steal_page and donate_page perhaps?) so it's not just a case or wiring
> > > > it up either.
> > > 
> > > Right.. I was confused by the fact that we do compile tmem_op in Linux,
> > > even though XEN_TMEM is actually not available on ARM or ARM64
> > 
> > I started from the other end and looked at what the hypervisor actually
> > implements rather than what Linux calls. It's useful to validate from
> > both angles though. For now I think we should stick with documenting
> > what the hypervisor provides even if the kernel might try and
> > optimistically call other stuff too.
> 
> So did we decide whether to run with this patch or not?

I would say a better option is to just disable by default tmem in Xen hypervisor
for ARM. So even if you boot with 'tmem=1' nothing will happen.

That way when I get an ARM box up and I can test tmem we can just revert that
simple patch without much trouble.

  reply	other threads:[~2013-07-29 18:09 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-22 18:17 [PATCH] xen: arm: document which hypercalls (and subops) are supported on ARM Ian Campbell
2013-07-23 11:33 ` Stefano Stabellini
2013-07-23 14:14   ` Ian Campbell
2013-07-23 15:34     ` Stefano Stabellini
2013-07-23 16:09       ` Konrad Rzeszutek Wilk
2013-07-23 16:59       ` Ian Campbell
2013-07-29 14:56         ` Ian Campbell
2013-07-29 18:09           ` Konrad Rzeszutek Wilk [this message]
2013-07-30  9:08             ` Ian Campbell
2013-08-08 10:59 ` Ian Campbell
2013-08-08 14:05   ` Tim Deegan
2013-08-08 15:25     ` Ian Campbell

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130729180929.GA13280@phenom.dumpdata.com \
    --to=konrad.wilk@oracle.com \
    --cc=Ian.Campbell@citrix.com \
    --cc=julien.grall@citrix.com \
    --cc=stefano.stabellini@eu.citrix.com \
    --cc=tim@xen.org \
    --cc=xen-devel@lists.xen.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.