From: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
To: Alexander Shiyan <shc_work@mail.ru>
Cc: linux-serial@vger.kernel.org, Jiri Slaby <jslaby@suse.cz>
Subject: Re: [PATCH] serial: max310x: Fix dev_pm_ops
Date: Mon, 29 Jul 2013 12:34:20 -0700 [thread overview]
Message-ID: <20130729193420.GA30737@kroah.com> (raw)
In-Reply-To: <1375111652-17436-1-git-send-email-shc_work@mail.ru>
On Mon, Jul 29, 2013 at 07:27:32PM +0400, Alexander Shiyan wrote:
> This patch fixes wrong dev_pm_ops which caused by commit:
> serial: max310x: Driver rework.
>
> CC drivers/tty/serial/max310x.o
> LD drivers/video/fb.o
> CC drivers/w1/slaves/w1_ds2433.o
> CC drivers/w1/slaves/w1_ds2760.o
> CC drivers/xen/balloon.o
> CC drivers/video/backlight/adp8870_bl.o
> drivers/tty/serial/max310x.c:1292:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: (near initialization for 'max310x_pm_ops.suspend') [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: (near initialization for 'max310x_pm_ops.resume') [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: (near initialization for 'max310x_pm_ops.freeze') [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: (near initialization for 'max310x_pm_ops.thaw') [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: (near initialization for 'max310x_pm_ops.poweroff') [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: initialization from incompatible pointer type [enabled by default]
> drivers/tty/serial/max310x.c:1292:8: warning: (near initialization for 'max310x_pm_ops.restore') [enabled by default]
>
> Signed-off-by: Alexander Shiyan <shc_work@mail.ru>
You forgot to put in the "Reported-by:" line saying who told you about
this problem...
I'll go do it this time, but in the future, please be more careful.
thanks,
greg k-h
prev parent reply other threads:[~2013-07-29 19:34 UTC|newest]
Thread overview: 2+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-29 15:27 [PATCH] serial: max310x: Fix dev_pm_ops Alexander Shiyan
2013-07-29 19:34 ` Greg Kroah-Hartman [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130729193420.GA30737@kroah.com \
--to=gregkh@linuxfoundation.org \
--cc=jslaby@suse.cz \
--cc=linux-serial@vger.kernel.org \
--cc=shc_work@mail.ru \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.