From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:46981)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3xtt-00085k-LJ
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 20:34:58 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3xtp-0005qo-AC
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 20:34:53 -0400
Received: from mx1.redhat.com ([209.132.183.28]:15982)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <lcapitulino@redhat.com>) id 1V3xtp-0005qO-3D
	for qemu-devel@nongnu.org; Mon, 29 Jul 2013 20:34:49 -0400
Date: Mon, 29 Jul 2013 20:34:44 -0400
From: Luiz Capitulino <lcapitulino@redhat.com>
Message-ID: <20130729203444.2f4b6a9f@redhat.com>
In-Reply-To: <87iozsq5lj.fsf@blackfin.pond.sub.org>
References: <51ED9E3F.3080504@hds.com> <51EDA2D1.5080603@suse.de>
	<20130729172018.302018df@redhat.com> <51F6DD54.2060503@suse.de>
	<20130729174544.104eecd0@redhat.com>
	<87iozsq5lj.fsf@blackfin.pond.sub.org>
Mime-Version: 1.0
Content-Type: text/plain; charset=UTF-8
Content-Transfer-Encoding: quoted-printable
Subject: Re: [Qemu-devel] [PATCH] Convert stderr message calling
 error_get_pretty() to error_report() to prepend timestamp
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Markus Armbruster <armbru@redhat.com>
Cc: Seiji Aguchi <seiji.aguchi@hds.com>, lersek@redhat.com, Andreas =?UTF-8?B?RsOkcmJlcg==?= <afaerber@suse.de>, tomoki.sekiyama@hds.com, qemu-devel@nongnu.org

On Tue, 30 Jul 2013 02:00:40 +0200
Markus Armbruster <armbru@redhat.com> wrote:

> Luiz Capitulino <lcapitulino@redhat.com> writes:
>=20
> > On Mon, 29 Jul 2013 23:23:32 +0200
> > Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> >
> >> Am 29.07.2013 23:20, schrieb Luiz Capitulino:
> >> > On Mon, 22 Jul 2013 23:23:29 +0200
> >> > Andreas F=C3=A4rber <afaerber@suse.de> wrote:
> >> >> Am 22.07.2013 23:03, schrieb Seiji Aguchi:
> >> >>> Convert stderr messages calling error_get_pretty()
> >> >>> to error_report().
> >> >>
> >> >> How is this related to error_get_pretty()?
> >> >=20
> >> > Yeah, we're converting fprintf(stderr,) calls to error_report() so t=
hat
> >> > error messages get a timestamp.
> >>=20
> >> Want to add that to my http://wiki.qemu.org/DeveloperNews so that peop=
le
> >> reading it stop adding new ones? :)
> >
> > Big IMHO here, but honestly speaking I'm not a huge fan of error_report=
()
> > because I think that random code shouldn't be allowed to print to the
> > monitor (only HMP code should).
>=20
> A conversion from fprintf() to error_report() is always an improvement,
> because

No disagreement here.