All of lore.kernel.org
 help / color / mirror / Atom feed
From: Zheng Liu <gnehzuil.liu@gmail.com>
To: Theodore Ts'o <tytso@mit.edu>
Cc: linux-ext4@vger.kernel.org, Jan Kara <jack@suse.cz>,
	Zheng Liu <wenqing.lz@taobao.com>
Subject: Re: [PATCH v2] ext4: remove the entry from es tree when bigalloc is enabled
Date: Tue, 30 Jul 2013 07:44:25 +0800	[thread overview]
Message-ID: <20130729234425.GB3648@gmail.com> (raw)
In-Reply-To: <20130729162151.GH11816@thunk.org>

On Mon, Jul 29, 2013 at 12:21:51PM -0400, Theodore Ts'o wrote:
> On Fri, Jul 26, 2013 at 07:42:06AM +0800, Zheng Liu wrote:
> > From: Jan Kara <jack@suse.cz>
> > 
> > Now in ext4_da_page_release_reservation() we remove the entry from es
> > tree if to_release != 0.  But there are two issues.  One is that it is
> > wrong when blocksize != pagesize,
> 
> The commit description says that this is wrong, but I don't see
> anything in the patch which addresses this.  And could you state what
> the impact is of this wrongness?

Sorry for my bad description.  As Jan said, this patch doesn't address
any issue.  It just makes the code clearly.  After applied this patch,
I still get the warning messages from ext4_da_release_space running
xfstests #74 when blocksize = 1k.

Thanks,
                                                - Zheng

  parent reply	other threads:[~2013-07-29 23:44 UTC|newest]

Thread overview: 6+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-25 23:42 [PATCH v2] ext4: remove the entry from es tree when bigalloc is enabled Zheng Liu
2013-07-29 15:07 ` Zheng Liu
2013-07-29 16:21 ` Theodore Ts'o
2013-07-29 17:50   ` Jan Kara
2013-07-29 23:44   ` Zheng Liu [this message]
2013-07-30 16:14     ` Jan Kara

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130729234425.GB3648@gmail.com \
    --to=gnehzuil.liu@gmail.com \
    --cc=jack@suse.cz \
    --cc=linux-ext4@vger.kernel.org \
    --cc=tytso@mit.edu \
    --cc=wenqing.lz@taobao.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.