From mboxrd@z Thu Jan 1 00:00:00 1970 From: Stephen Boyd Subject: Re: [PATCH] hwspinlock/msm: Add support for Qualcomm MSM HW Mutex block Date: Mon, 29 Jul 2013 17:28:49 -0700 Message-ID: <20130730002849.GE8868@codeaurora.org> References: <1375128719-23642-1-git-send-email-galak@codeaurora.org> <20130729214035.GC8868@codeaurora.org> <9EB1A821-7137-4812-B58A-20F669BCA7DD@codeaurora.org> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <9EB1A821-7137-4812-B58A-20F669BCA7DD@codeaurora.org> Sender: linux-kernel-owner@vger.kernel.org To: Kumar Gala Cc: ohad@wizery.com, "linux-kernel@vger.kernel.org list" , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, Jeffrey Hugo , Eric Holmberg List-Id: linux-arm-msm@vger.kernel.org On 07/29, Kumar Gala wrote: > > On Jul 29, 2013, at 4:40 PM, Stephen Boyd wrote: > > > On 07/29, Kumar Gala wrote: > >>> +#include > >>> +#include > >>> + > >>> +#include > > > > please. > > will change, I choice since *_relaxed are arm specific. > I thought readl_relaxed() was universal for HAS_IOMEM arches. Unfortunately writel_relaxed() isn't defined on all arches. Luckily this driver depends on ARCH_MSM so it isn't a problem. Perhaps it should just depend on HAS_IOMEM so we can use it on arm64 and/or hexagon in the future without having to change the Kconfig. That would require introducing writel_relaxed() into the other arches that don't have it right now. -- Qualcomm Innovation Center, Inc. is a member of Code Aurora Forum, hosted by The Linux Foundation