All of lore.kernel.org
 help / color / mirror / Atom feed
From: Steffen Klassert <steffen.klassert@secunet.com>
To: netdev@vger.kernel.org, vi0oss@gmail.com, hannes@stressinduktion.org
Subject: Re: [PATCH RFC] xfrm{4,6}: only report errors back to local sockets if we don't cross address family
Date: Tue, 30 Jul 2013 10:21:18 +0200	[thread overview]
Message-ID: <20130730082118.GA25511@secunet.com> (raw)
In-Reply-To: <20130729145017.GD2490@order.stressinduktion.org>

On Mon, Jul 29, 2013 at 04:50:17PM +0200, Hannes Frederic Sowa wrote:
> xfrm6_local_error/xfrm4_tunnel_check_size report mtu errors back to a
> socket in case it is locally generated. If the packet first traversed
> a 6in4/4in6 tunnel before passing the xfrm layer, we could get a panic
> because of address family type mismatch in the error reporting functions.
> 

So the skb is still owned by a socket of the inner address family.
Is this intentional? Maybe the ndo_start_xmit() function of the
tunnel device should orphan the skb if we tunnel the packet
through a different address family.

  reply	other threads:[~2013-07-30  8:21 UTC|newest]

Thread overview: 16+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-07-29 14:50 [PATCH RFC] xfrm{4,6}: only report errors back to local sockets if we don't cross address family Hannes Frederic Sowa
2013-07-30  8:21 ` Steffen Klassert [this message]
2013-07-30  8:30   ` Hannes Frederic Sowa
2013-07-30 10:26     ` Steffen Klassert
2013-07-30 10:40       ` Hannes Frederic Sowa
2013-07-31  0:01         ` David Miller
2013-08-01  8:11       ` Hannes Frederic Sowa
2013-08-01 10:05         ` Steffen Klassert
2013-08-08 22:44           ` Hannes Frederic Sowa
2013-08-08 22:57             ` Eric Dumazet
2013-08-08 23:06               ` Hannes Frederic Sowa
2013-08-10 16:16                 ` Hannes Frederic Sowa
2013-08-12  5:54                   ` Steffen Klassert
2013-08-13  0:48                     ` [PATCH net-next] xfrm: make local error reporting more robust Hannes Frederic Sowa
2013-08-13  1:56                     ` [PATCH net-next v2] " Hannes Frederic Sowa
2013-08-13 23:35                       ` David Miller

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130730082118.GA25511@secunet.com \
    --to=steffen.klassert@secunet.com \
    --cc=hannes@stressinduktion.org \
    --cc=netdev@vger.kernel.org \
    --cc=vi0oss@gmail.com \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.