From: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
To: Tejun Heo <tj@kernel.org>
Cc: linux-ide@vger.kernel.org, Andrew Lunn <andrew@lunn.ch>,
Lior Amsalem <alior@marvell.com>,
Thomas Petazzoni <thomas.petazzoni@free-electrons.com>,
Gregory Clement <gregory.clement@free-electrons.com>
Subject: Re: [PATCH v2] ATA: sata_mv: Remove unneeded CONFIG_HAVE_CLK ifdefs
Date: Tue, 30 Jul 2013 10:16:28 -0300 [thread overview]
Message-ID: <20130730131626.GC2375@localhost> (raw)
In-Reply-To: <20130730130411.GC12016@htj.dyndns.org>
On Tue, Jul 30, 2013 at 09:04:11AM -0400, Tejun Heo wrote:
> On Mon, Jul 29, 2013 at 11:46:03PM -0300, Ezequiel Garcia wrote:
> > If CONFIG_HAVE_CLK is not selected, then all the clk API turn out
> > into no-ops. In other words, there's no need to have the ifdefs.
> >
> > The only side-effect of this patch is the extra tiny kmalloc,
> > but that's not enough reason to have such ugly ifdefs all around
> > the code.
> >
> > Signed-off-by: Ezequiel Garcia <ezequiel.garcia@free-electrons.com>
>
> Applied to libata/for-3.12 with Andrew's comment suggestion applied
> and acked-by added.
>
Great, thanks for taking care of that.
--
Ezequiel García, Free Electrons
Embedded Linux, Kernel and Android Engineering
http://free-electrons.com
prev parent reply other threads:[~2013-07-30 13:16 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-30 2:46 [PATCH v2] ATA: sata_mv: Remove unneeded CONFIG_HAVE_CLK ifdefs Ezequiel Garcia
2013-07-30 7:05 ` Andrew Lunn
2013-07-30 13:04 ` Tejun Heo
2013-07-30 13:16 ` Ezequiel Garcia [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730131626.GC2375@localhost \
--to=ezequiel.garcia@free-electrons.com \
--cc=alior@marvell.com \
--cc=andrew@lunn.ch \
--cc=gregory.clement@free-electrons.com \
--cc=linux-ide@vger.kernel.org \
--cc=thomas.petazzoni@free-electrons.com \
--cc=tj@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.