From: Luiz Capitulino <lcapitulino@redhat.com>
To: Kevin Wolf <kwolf@redhat.com>
Cc: qemu-devel@nongnu.org, stefanha@redhat.com, armbru@redhat.com
Subject: Re: [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command
Date: Tue, 30 Jul 2013 13:44:23 -0400 [thread overview]
Message-ID: <20130730134423.63800a98@redhat.com> (raw)
In-Reply-To: <20130726181406.GG18446@dhcp-200-207.str.redhat.com>
On Fri, 26 Jul 2013 20:14:06 +0200
Kevin Wolf <kwolf@redhat.com> wrote:
> Am 26.07.2013 um 19:45 hat Eric Blake geschrieben:
> > Overall, I like where this is headed, but I'm not quite sure it is ready
> > for commit as-is; looking forward to v2. Given my positive review on
> > the rest of the series, I think you could get away with a pull request
> > on the front half of the series and only respinning this patch, instead
> > of needing (re-)review of the entire series.
>
> Yup, that's exactly what I'm going to do now. I had considered merging
> the whole series, but I think you're right that committing it now might
> be a bit early. My main concern were potential conflicts in the front
> "half" (17/18) of the series when I'd wait too long with committing.
Just to double check I got it as I'm still catching up with email
after vacation: you did exactly what was suggested by Eric, you
merged 1-17 and will post the blockdev-add command for 1.7?
next prev parent reply other threads:[~2013-07-30 17:44 UTC|newest]
Thread overview: 61+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-23 13:03 [Qemu-devel] [PATCH 00/18] 'blockdev-add' QMP command Kevin Wolf
2013-07-23 13:03 ` [Qemu-devel] [PATCH 01/18] qapi-types.py: Split off generate_struct_fields() Kevin Wolf
2013-07-25 23:06 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 02/18] qapi-types.py: Implement 'base' for unions Kevin Wolf
2013-07-25 23:12 ` Eric Blake
2013-08-21 3:38 ` Amos Kong
2013-08-27 15:58 ` Kevin Wolf
2013-08-29 13:52 ` Luiz Capitulino
2013-08-29 16:06 ` Kevin Wolf
2013-08-29 16:33 ` Luiz Capitulino
2013-08-29 16:50 ` Kevin Wolf
2013-08-29 17:02 ` Eric Blake
2013-08-29 18:36 ` Luiz Capitulino
2013-08-30 7:30 ` Wenchao Xia
2013-07-23 13:03 ` [Qemu-devel] [PATCH 03/18] qapi-visit.py: Split off generate_visit_struct_fields() Kevin Wolf
2013-07-25 23:15 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 04/18] qapi-visit.py: Implement 'base' for unions Kevin Wolf
2013-07-25 23:19 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 05/18] docs: Document QAPI union types Kevin Wolf
2013-07-26 13:06 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 06/18] qapi: Add visitor for implicit structs Kevin Wolf
2013-07-26 13:12 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 07/18] qapi: Flat unions with arbitrary discriminator Kevin Wolf
2013-07-26 13:40 ` Eric Blake
2013-07-26 15:01 ` Kevin Wolf
2013-07-26 15:13 ` Eric Blake
2013-07-26 19:16 ` [Qemu-devel] [PATCH v2 07/17] " Kevin Wolf
2013-07-26 19:36 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 08/18] qapi: Add consume argument to qmp_input_get_object() Kevin Wolf
2013-07-26 15:13 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 09/18] qapi.py: Maintain a list of union types Kevin Wolf
2013-07-26 15:26 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 10/18] qapi: Anonymous unions Kevin Wolf
2013-07-26 15:42 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 11/18] block: Allow "driver" option on the top level Kevin Wolf
2013-07-26 16:00 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 12/18] QemuOpts: Add qemu_opt_unset() Kevin Wolf
2013-07-26 16:04 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 13/18] blockdev: Rename I/O throttling options for QMP Kevin Wolf
2013-07-26 16:10 ` Eric Blake
2013-07-26 16:26 ` Kevin Wolf
2013-07-26 16:44 ` Eric Blake
2013-07-26 16:54 ` Kevin Wolf
2013-07-26 17:01 ` Eric Blake
2013-07-26 19:35 ` Benoît Canet
2013-07-26 19:54 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 14/18] qcow2: Use dashes instead of underscores in options Kevin Wolf
2013-07-26 16:17 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 15/18] blockdev: Rename 'readonly' option to 'read-only' Kevin Wolf
2013-07-26 16:20 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 16/18] blockdev: Split up 'cache' option Kevin Wolf
2013-07-26 16:30 ` Eric Blake
2013-07-23 13:03 ` [Qemu-devel] [PATCH 17/18] Implement qdict_flatten() Kevin Wolf
2013-07-26 16:40 ` Eric Blake
2013-07-26 17:03 ` Kevin Wolf
2013-07-23 13:03 ` [Qemu-devel] [PATCH 18/18] blockdev: 'blockdev-add' QMP command Kevin Wolf
2013-07-26 17:45 ` Eric Blake
2013-07-26 18:14 ` Kevin Wolf
2013-07-30 17:44 ` Luiz Capitulino [this message]
2013-07-31 8:09 ` Kevin Wolf
2013-08-30 7:41 ` Wenchao Xia
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130730134423.63800a98@redhat.com \
--to=lcapitulino@redhat.com \
--cc=armbru@redhat.com \
--cc=kwolf@redhat.com \
--cc=qemu-devel@nongnu.org \
--cc=stefanha@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.