From mboxrd@z Thu Jan 1 00:00:00 1970 From: rwxybh Subject: Re: [PATCH] Fix function libxl__domain_resume_device_model Date: Tue, 30 Jul 2013 20:39:38 +0800 Message-ID: <2013073020393614338768@126.com> References: <1375144646-3780-1-git-send-email-rwxybh@126.com> , <1375187323.11701.106.camel@kazak.uk.xensource.com> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============2390918897576273391==" Return-path: List-Unsubscribe: , List-Post: List-Help: List-Subscribe: , Sender: xen-devel-bounces@lists.xen.org Errors-To: xen-devel-bounces@lists.xen.org To: Ian Campbell , Wei Liu Cc: "rwxybh@123.com" , xen-devel List-Id: xen-devel@lists.xenproject.org This is a multi-part message in MIME format. --===============2390918897576273391== Content-Type: multipart/alternative; boundary="----=_001_NextPart616050318365_=----" This is a multi-part message in MIME format. ------=_001_NextPart616050318365_=---- Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: base64 T2YgY291cnNlLCBJYW4uDQoNCkZyb206IElhbiBDYW1wYmVsbA0KRGF0ZTogMjAxMy0wNy0zMCAy MDoyOA0KVG86IFdlaSBMaXUNCkNDOiByd3h5Ymg7IHJ3eHliaEAxMjMuY29tOyB4ZW4tZGV2ZWxA bGlzdHMueGVuLm9yZw0KU3ViamVjdDogUmU6IFtYZW4tZGV2ZWxdIFtQQVRDSF0gRml4IGZ1bmN0 aW9uIGxpYnhsX19kb21haW5fcmVzdW1lX2RldmljZV9tb2RlbA0KT24gVHVlLCAyMDEzLTA3LTMw IGF0IDIwOjAwICswODAwLCBXZWkgTGl1IHdyb3RlOg0KPiBPbiBUdWUsIEp1bCAzMCwgMjAxMyBh dCA4OjM3IEFNLCByd3h5YmggPHJ3eHliaEAxMjYuY29tPiB3cm90ZToNCj4gPiBBZGQgYSBicmVh ayBwb2ludCBpbiBmdW5jdGlvbiBsaWJ4bF9fZG9tYWluX3Jlc3VtZV9kZXZpY2VfbW9kZWwNCj4g Pg0KPiA+IFNpZ25lZC1vZmYtYnk6IHJ3eHliaCA8cnd4eWJoQDEyNi5jb20+DQo+IA0KPiBJcyBp dCBPSyB0byB1c2UgYWxpYXMgcmF0aGVyIHRoYW4gcmVhbCBuYW1lIGluIFNvQj8gSSByZW1lbWJl ciBzZWVpbmcgdGhhdA0KPiBhdXRob3Igc2hvdWxkIHVzZSByZWFsIG5hbWUgaW4gU29CIGJ1dCBJ J20gbm90IHN1cmUuIElnbm9yZSB0aGlzIGlmIEknbSB3cm9uZy4NCg0KSSBrbm93IHRoZSBMaW51 eCBndXlzIGhhdmUgYmVlbiBwaWNreSBhYm91dCB0aGlzIGluIHRoZSBwYXN0LCBhbHRob3VnaA0K SSdtIG5vdCBzdXJlIHRoZXkgYXJlIDEwMCUgY29uc2lzdGVudCAodGhlIG9uZSBJJ20gdGhpbmtp bmcgb2YgaGFkIG90aGVyDQpzdXJyb3VuZGluZyBjb250cm92ZXJzeSkuDQoNCkluIGFueSBjYXNl IHNpbmNlIHJ3eHliaCBoYXMgcHJldmlvdXNseSBwb3N0ZWQgd2l0aCB0aGVpciByZWFsIG5hbWUg SQ0KdGhpbmsgaXQgd291bGQgYmUgT0sgdG8gYXNrIGZvciBhbiBTLW8tYiBjb250YWluaW5nIGl0 IGFuZCBzaWRlc3RlcA0KaGF2aW5nIHRvIHRoaW5rIGFib3V0IHRoZSBpc3N1ZT8gQmluZ2hlbmcs IGFyZSB5b3UgT0sgd2l0aCBtZSB1c2luZyB0aGUNCmZvbGxvd2luZyBTLW8tYiBpbnN0ZWFkIG9m IHRoZSBvbmUgYWJvdmU/DQoNCj4gU2lnbmVkLW9mZi1ieTogQmluZ2hlbmcgWWFuIDxyd3h5YmhA MTI2LmNvbT4NCg0KSWFuLg0KDQo+IA0KPiANCj4gV2VpLg0KPiANCj4gPiAtLS0NCj4gPiAgdG9v bHMvbGlieGwvbGlieGxfZG9tLmMgfCAgICAxICsNCj4gPiAgMSBmaWxlcyBjaGFuZ2VkLCAxIGlu c2VydGlvbnMoKyksIDAgZGVsZXRpb25zKC0pDQo+ID4NCj4gPiBkaWZmIC0tZ2l0IGEvdG9vbHMv bGlieGwvbGlieGxfZG9tLmMgYi90b29scy9saWJ4bC9saWJ4bF9kb20uYw0KPiA+IGluZGV4IGIz OGQwYTcuLjNlYWYzYWUgMTAwNjQ0DQo+ID4gLS0tIGEvdG9vbHMvbGlieGwvbGlieGxfZG9tLmMN Cj4gPiArKysgYi90b29scy9saWJ4bC9saWJ4bF9kb20uYw0KPiA+IEBAIC05ODUsNiArOTg1LDcg QEAgaW50IGxpYnhsX19kb21haW5fcmVzdW1lX2RldmljZV9tb2RlbChsaWJ4bF9fZ2MgKmdjLCB1 aW50MzJfdCBkb21pZCkNCj4gPiAgICAgIGNhc2UgTElCWExfREVWSUNFX01PREVMX1ZFUlNJT05f UUVNVV9YRU46DQo+ID4gICAgICAgICAgaWYgKGxpYnhsX19xbXBfcmVzdW1lKGdjLCBkb21pZCkp DQo+ID4gICAgICAgICAgICAgIHJldHVybiBFUlJPUl9GQUlMOw0KPiA+ICsgICAgICAgYnJlYWs7 DQo+ID4gICAgICBkZWZhdWx0Og0KPiA+ICAgICAgICAgIHJldHVybiBFUlJPUl9JTlZBTDsNCj4g PiAgICAgIH0NCj4gPiAtLQ0KPiA+IDEuNy4xDQo+ID4NCj4gPg0KPiA+DQo+ID4gX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18NCj4gPiBYZW4tZGV2ZWwgbWFp bGluZyBsaXN0DQo+ID4gWGVuLWRldmVsQGxpc3RzLnhlbi5vcmcNCj4gPiBodHRwOi8vbGlzdHMu eGVuLm9yZy94ZW4tZGV2ZWwNCj4gDQo+IF9fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fDQo+IFhlbi1kZXZlbCBtYWlsaW5nIGxpc3QNCj4gWGVuLWRldmVsQGxp c3RzLnhlbi5vcmcNCj4gaHR0cDovL2xpc3RzLnhlbi5vcmcveGVuLWRldmVs ------=_001_NextPart616050318365_=---- Content-Type: text/html; charset="UTF-8" Content-Transfer-Encoding: quoted-printable =EF=BB=BF
Of course, Ian.
 
Date: 2013-07-30 20:28
To: Wei Liu
CC: rwxybh; rwxybh@123.com; xen-devel@lists.xen.org
Subject: Re: [Xen-devel] [PATCH] Fix function=20 libxl__domain_resume_device_model
On Tue, 2013-07-30 at 20:00 +0800, Wei Liu wrote:
> On Tue, Jul 30, 2013 at 8:37 AM, rwxybh <rwxybh@126.com>=20 wrote:
> > Add a break point in function=20 libxl__domain_resume_device_model
> >
> > Signed-off-by: rwxybh <rwxybh@126.com>
>
> Is it OK to use alias rather than real name in SoB? I remember s= eeing=20 that
> author should use real name in SoB but I'm not sure. Ignore this= if=20 I'm wrong.
 
I know the Linux guys have been picky about this in the past,=20 although
I'm not sure they are 100% consistent (the one I'm thinking of had=20 other
surrounding controversy).
 
In any case since rwxybh has previously posted with their real name I=
think it would be OK to ask for an S-o-b containing it and sidestep
having to think about the issue? Bingheng, are you OK with me using=20 the
following S-o-b instead of the one above?
 
> Signed-off-by: Bingheng Yan <rwxybh@126.com>
 
Ian.
 
>
>
> Wei.
>
> > ---
> >  tools/libxl/libxl_dom.c |    1 +
> >  1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/tools/libxl/libxl_dom.c=20 b/tools/libxl/libxl_dom.c
> > index b38d0a7..3eaf3ae 100644
> > --- a/tools/libxl/libxl_dom.c
> > +++ b/tools/libxl/libxl_dom.c
> > @@ -985,6 +985,7 @@ int=20 libxl__domain_resume_device_model(libxl__gc *gc, uint32_t domid)
> >      case=20 LIBXL_DEVICE_MODEL_VERSION_QEMU_XEN:
> >          if=20 (libxl__qmp_resume(gc, domid))
>=20 >           &nbs= p; =20 return ERROR_FAIL;
> > +       break;
> >      default:
> >          retur= n=20 ERROR_INVAL;
> >      }
> > --
> > 1.7.1
> >
> >
> >
> > _______________________________________________
> > Xen-devel mailing list
> > Xen-devel@lists.xen.org
> > http://lists.xen.org/xen-devel
>
> _______________________________________________
> Xen-devel mailing list
> Xen-devel@lists.xen.org
> http://lists.xen.org/xen-devel
 
 
------=_001_NextPart616050318365_=------ --===============2390918897576273391== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Xen-devel mailing list Xen-devel@lists.xen.org http://lists.xen.org/xen-devel --===============2390918897576273391==--