Re: [PATCH] hugetlb: fix lockdep splat caused by pmd sharing

[Dave Jones <davej@redhat.com>]

On Wed, Jul 31, 2013 at 08:35:30AM +0900, Minchan Kim wrote:
 > > which is a false positive caused by hugetlb pmd sharing code which
 > > allocates a new pmd from withing mappint->i_mmap_mutex. If this
 > > allocation causes reclaim then the lockdep detector complains that we
 > > might self-deadlock.
 > > 
 > > This is not correct though, because hugetlb pages are not reclaimable so
 > > their mapping will be never touched from the reclaim path.
 > > 
 > > The patch tells lockup detector that hugetlb i_mmap_mutex is special
 > > by assigning it a separate lockdep class so it won't report possible
 > > deadlocks on unrelated mappings.
 > > 
 > > [peterz@infradead.org: comment for annotation]
 > > Reported-by: Dave Jones <davej@redhat.com>
 > > Signed-off-by: Michal Hocko <mhocko@suse.cz>
 > Reviewed-by: Minchan Kim <minchan@kernel.org>
 > 
 > Thanks, Michal!
 > Only remained thing is Dave's testing.

I've added it to my builds, all is quiet so far..

	Dave





--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org.  For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>