From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ben Widawsky Subject: Re: [PATCH] drm/i915: Squelch repeated reasoning for why FBC cannot be activated Date: Wed, 31 Jul 2013 00:43:55 -0700 Message-ID: <20130731074355.GD24641@bwidawsk.net> References: <1374942235-8530-1-git-send-email-chris@chris-wilson.co.uk> <20130727221315.GA814@bwidawsk.net> <20130727223016.GA31724@cantiga.alporthouse.com> <20130727225629.GB814@bwidawsk.net> <20130727230216.GB31724@cantiga.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from mail.bwidawsk.net (bwidawsk.net [166.78.191.112]) by gabe.freedesktop.org (Postfix) with ESMTP id 06CEEE6291 for ; Wed, 31 Jul 2013 00:51:21 -0700 (PDT) Content-Disposition: inline In-Reply-To: <20130727230216.GB31724@cantiga.alporthouse.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Sun, Jul 28, 2013 at 12:02:16AM +0100, Chris Wilson wrote: > On Sat, Jul 27, 2013 at 03:56:29PM -0700, Ben Widawsky wrote: > > What I meant is, you don't want it to return true if you go from: > > FBC_OFF_FOR_REASON_A->FBC_OFF_FOR_REASON_B > > > > Only when you go from: > > FBC_OK -> !FBC_OK > > I wanted the A -> B messages as when looking at the logs knowing the > current reason why FBC is disabled is important (imo). > -Chris > > -- > Chris Wilson, Intel Open Source Technology Centre Merged this to my temporary tree for when Daniel returns. -- Ben Widawsky, Intel Open Source Technology Center