From: Dimitris Papastamos <dp@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: alsa-devel@alsa-project.org, patches@opensource.wolfsonmicro.com
Subject: Re: [PATCH] ASoC: wm0010: Fix resource leak
Date: Wed, 31 Jul 2013 13:00:25 +0100 [thread overview]
Message-ID: <20130731120025.GA26590@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130731112331.GL9858@sirena.org.uk>
On Wed, Jul 31, 2013 at 12:23:31PM +0100, Mark Brown wrote:
> On Wed, Jul 31, 2013 at 10:15:18AM +0100, Dimitris Papastamos wrote:
>
> > + xfer = kzalloc(sizeof(*xfer), GFP_KERNEL | GFP_DMA);
> > + if (!xfer) {
> > + dev_err(codec->dev, "Failed to allocate xfer\n");
> > + ret = -ENOMEM;
> > + goto abort1;
> > + }
> > +
>
> Why is this being allocated with GFP_DMA? It's an internal data
> structure, it's not going to be DMAed from.
Yeah I will send a separate patch to fix that and then rebase
this patch on top.
> Please also provide a changelog, a link to some address on the web isn't
> a useful description.
Will do.
next prev parent reply other threads:[~2013-07-31 12:00 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 9:15 [PATCH] ASoC: wm0010: Fix resource leak Dimitris Papastamos
2013-07-31 11:23 ` Mark Brown
2013-07-31 12:00 ` Dimitris Papastamos [this message]
2013-07-31 12:03 ` Dimitris Papastamos
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130731120025.GA26590@opensource.wolfsonmicro.com \
--to=dp@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=patches@opensource.wolfsonmicro.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.