From: "Michael S. Tsirkin" <mst@redhat.com>
To: Sergei Shtylyov <sergei.shtylyov@cogentembedded.com>
Cc: linux-kernel@vger.kernel.org,
"David S. Miller" <davem@davemloft.net>,
Roopa Prabhu <roprabhu@cisco.com>,
John Fastabend <john.r.fastabend@intel.com>,
Patrick McHardy <kaber@trash.net>,
netdev@vger.kernel.org
Subject: Re: [PATCH] macvlan: validate flags
Date: Thu, 1 Aug 2013 17:45:28 +0300 [thread overview]
Message-ID: <20130801144528.GA16896@redhat.com> (raw)
In-Reply-To: <51FA7255.1070102@cogentembedded.com>
On Thu, Aug 01, 2013 at 06:36:05PM +0400, Sergei Shtylyov wrote:
> Hello.
>
> On 01-08-2013 14:48, Michael S. Tsirkin wrote:
>
> >commit df8ef8f3aaa6692970a436204c4429210addb23a
>
> Please also specify that commit's summary line in parens.
> This is the only way to uniquely identify the commit, and it's the
> requirement that came originally from Linus AFAIK.
Ouch, no idea why do I keep making this mistake.
Will do, thanks.
> >added a flags field to macvlan, which can be
> >controlled from userspace.
> >The idea is to make the interface future-proof
> >so we can add flags and not new fields.
>
> >However, flags value isn't validated, as a result,
> >userspace can't detect which flags are supported.
>
> >Cc: "David S. Miller" <davem@davemloft.net>
> >CC: Roopa Prabhu <roprabhu@cisco.com>
> >Cc: John Fastabend <john.r.fastabend@intel.com>
> >Signed-off-by: Michael S. Tsirkin <mst@redhat.com>
>
> WBR, Sergei
prev parent reply other threads:[~2013-08-01 14:44 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 10:48 [PATCH] macvlan: validate flags Michael S. Tsirkin
2013-08-01 14:36 ` Sergei Shtylyov
2013-08-01 14:45 ` Michael S. Tsirkin [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801144528.GA16896@redhat.com \
--to=mst@redhat.com \
--cc=davem@davemloft.net \
--cc=john.r.fastabend@intel.com \
--cc=kaber@trash.net \
--cc=linux-kernel@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=roprabhu@cisco.com \
--cc=sergei.shtylyov@cogentembedded.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.