From: Richard Fitzgerald <rf@opensource.wolfsonmicro.com>
To: Mark Brown <broonie@kernel.org>
Cc: lgirdwood@gmail.com, perex@perex.cz, tiwai@suse.de,
alsa-devel@alsa-project.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH] ASoC: core: init delayed_work for codec-codec links
Date: Thu, 1 Aug 2013 16:50:56 +0100 [thread overview]
Message-ID: <20130801155056.GA3996@opensource.wolfsonmicro.com> (raw)
In-Reply-To: <20130801152356.GW9858@sirena.org.uk>
On Thu, Aug 01, 2013 at 04:23:56PM +0100, Mark Brown wrote:
> On Thu, Aug 01, 2013 at 04:13:52PM +0100, Richard Fitzgerald wrote:
> > On Wed, Jul 31, 2013 at 02:25:22PM +0100, Mark Brown wrote:
>
> > > Why is this better than pointing at the normal work that you'd expect to
> > > be used there?
>
> > By 'normal work' do you mean the close_delayed_work() used for
> > standard PCM DAIs?
>
> Yes - making up this empty work doesn't seem like a robust approach.
Yeah, I think the problem is more one of bad naming. I should define that
function as the delayed work for codec-2-codec links, it just happens
that we don't currently have to do anything for them. The only thing
the pcm close_delayed_work() does is to send a SND_SOC_DAPM_STREAM_STOP
but for c2c links we never send a start anyway.
next prev parent reply other threads:[~2013-08-01 15:50 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-31 13:16 [PATCH] ASoC: core: init delayed_work for codec-codec links Richard Fitzgerald
2013-07-31 13:16 ` Richard Fitzgerald
2013-07-31 13:25 ` Mark Brown
2013-07-31 13:25 ` Mark Brown
2013-08-01 15:13 ` Richard Fitzgerald
2013-08-01 15:23 ` Mark Brown
2013-08-01 15:23 ` Mark Brown
2013-08-01 15:50 ` Richard Fitzgerald [this message]
2013-08-01 18:47 ` Mark Brown
2013-08-02 10:01 ` [PATCH v2] " Richard Fitzgerald
2013-08-02 10:14 ` Mark Brown
2013-08-02 10:14 ` Mark Brown
2013-08-02 10:51 ` [PATCH v3] " Richard Fitzgerald
2013-08-02 10:51 ` [alsa-devel] " Richard Fitzgerald
2013-08-05 10:33 ` Mark Brown
2013-08-05 12:17 ` [PATCH v4] " Richard Fitzgerald
2013-08-05 12:17 ` [alsa-devel] " Richard Fitzgerald
2013-08-05 16:09 ` Mark Brown
2013-08-05 16:09 ` [alsa-devel] " Mark Brown
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130801155056.GA3996@opensource.wolfsonmicro.com \
--to=rf@opensource.wolfsonmicro.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=perex@perex.cz \
--cc=tiwai@suse.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.