From: Wanpeng Li <liwanp@linux.vnet.ibm.com>
To: Joonsoo Kim <iamjoonsoo.kim@lge.com>
Cc: Andrew Morton <akpm@linux-foundation.org>,
linux-mm@kvack.org, linux-kernel@vger.kernel.org,
Zhang Yanfei <zhangyanfei@cn.fujitsu.com>,
Joonsoo Kim <js1304@gmail.com>,
Johannes Weiner <hannes@cmpxchg.org>
Subject: Re: [PATCH 1/2] mm, vmalloc: remove useless variable in vmap_block
Date: Fri, 2 Aug 2013 16:14:01 +0800 [thread overview]
Message-ID: <20130802081401.GA14447@hacker.(null)> (raw)
In-Reply-To: <1375408621-16563-1-git-send-email-iamjoonsoo.kim@lge.com>
On Fri, Aug 02, 2013 at 10:57:00AM +0900, Joonsoo Kim wrote:
>vbq in vmap_block isn't used. So remove it.
>
>Signed-off-by: Joonsoo Kim <iamjoonsoo.kim@lge.com>
>
Reviewed-by: Wanpeng Li <liwanp@linux.vnet.ibm.com>
>diff --git a/mm/vmalloc.c b/mm/vmalloc.c
>index 13a5495..d23c432 100644
>--- a/mm/vmalloc.c
>+++ b/mm/vmalloc.c
>@@ -752,7 +752,6 @@ struct vmap_block_queue {
> struct vmap_block {
> spinlock_t lock;
> struct vmap_area *va;
>- struct vmap_block_queue *vbq;
> unsigned long free, dirty;
> DECLARE_BITMAP(dirty_map, VMAP_BBMAP_BITS);
> struct list_head free_list;
>@@ -830,7 +829,6 @@ static struct vmap_block *new_vmap_block(gfp_t gfp_mask)
> radix_tree_preload_end();
>
> vbq = &get_cpu_var(vmap_block_queue);
>- vb->vbq = vbq;
> spin_lock(&vbq->lock);
> list_add_rcu(&vb->free_list, &vbq->free);
> spin_unlock(&vbq->lock);
>--
>1.7.9.5
>
>--
>To unsubscribe, send a message with 'unsubscribe linux-mm' in
>the body to majordomo@kvack.org. For more info on Linux MM,
>see: http://www.linux-mm.org/ .
>Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
--
To unsubscribe, send a message with 'unsubscribe linux-mm' in
the body to majordomo@kvack.org. For more info on Linux MM,
see: http://www.linux-mm.org/ .
Don't email: <a href=mailto:"dont@kvack.org"> email@kvack.org </a>
next prev parent reply other threads:[~2013-08-02 8:14 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 1:57 [PATCH 1/2] mm, vmalloc: remove useless variable in vmap_block Joonsoo Kim
2013-08-02 1:57 ` Joonsoo Kim
2013-08-02 1:57 ` [PATCH 2/2] mm, vmalloc: use well-defined find_last_bit() func Joonsoo Kim
2013-08-02 1:57 ` Joonsoo Kim
2013-08-02 8:28 ` Wanpeng Li
2013-08-02 8:28 ` Wanpeng Li
2013-08-02 19:22 ` Johannes Weiner
2013-08-02 19:22 ` Johannes Weiner
2013-08-03 0:46 ` Yanfei Zhang
2013-08-02 8:14 ` Wanpeng Li [this message]
2013-08-02 8:14 ` [PATCH 1/2] mm, vmalloc: remove useless variable in vmap_block Wanpeng Li
2013-08-02 19:15 ` Johannes Weiner
2013-08-02 19:15 ` Johannes Weiner
2013-08-03 0:38 ` Yanfei Zhang
2013-08-03 0:44 ` Yanfei Zhang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='20130802081401.GA14447@hacker.(null)' \
--to=liwanp@linux.vnet.ibm.com \
--cc=akpm@linux-foundation.org \
--cc=hannes@cmpxchg.org \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mm@kvack.org \
--cc=zhangyanfei@cn.fujitsu.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.