Re: [PATCH 1/2] mmc: dw_mmc-socfpga: Staticize dw_mci_socfpga_probe()

[Dan Carpenter <dan.carpenter@oracle.com>]

On Fri, Aug 02, 2013 at 09:11:19AM +0900, Jingoo Han wrote:
> On Friday, August 02, 2013 1:19 AM, Dinh Nguyen wrote:
> > drivers/mmc/host/dw_mmc-pltfm.c:58:24: warning: incorrect type in
> > argument 1 (different address spaces)
> > drivers/mmc/host/dw_mmc-pltfm.c:58:24:    expected void const *ptr
> > drivers/mmc/host/dw_mmc-pltfm.c:58:24:    got void [noderef]
> > <asn:2>*regs
> > drivers/mmc/host/dw_mmc-pltfm.c:59:36: warning: incorrect type in
> > argument 1 (different address spaces)
> > drivers/mmc/host/dw_mmc-pltfm.c:59:36:    expected void const *ptr
> > drivers/mmc/host/dw_mmc-pltfm.c:59:36:    got void [noderef]
> > <asn:2>*regs
> 
> You mean the following.
> 
> 58 if (IS_ERR(host->regs))
> 59                return PTR_ERR(host->regs);
> 
> >From v3.11-rc1, it does not make sparse warnings,
> because of the commit e7152b9 "err.h: IS_ERR() can accept __user pointers"
> submitted by Dan Carpenter.

You have to upgrade to a later version of Sparse as well.

> 
> 
> > drivers/mmc/host/dw_mmc-pltfm.c:36:5: warning: symbol
> > 'dw_mci_pltfm_register' was not declared. Should it be static?
> > drivers/mmc/host/dw_mmc-pltfm.c:94:1: warning: symbol
> > 'dw_mci_pltfm_pmops' was not declared. Should it be static?
> 
> 'dw_mci_pltfm_register' and 'dw_mci_pltfm_pmops' are exported as below:
> 
> 70: EXPORT_SYMBOL_GPL(dw_mci_pltfm_register);
> 95: EXPORT_SYMBOL_GPL(dw_mci_pltfm_pmops);
> 
> So, I am not sure whether these can be static or not. :(
> Dan, if you know how to handle this, please let me know.

No, don't make these static.  The way to silence this warning is to
include "dw_mmc-pltfm.h".

regards,
dan carpenter