From: Peter Zijlstra <peterz@infradead.org>
To: Preeti U Murthy <preeti@linux.vnet.ibm.com>
Cc: 김준수 <iamjoonsoo.kim@lge.com>, "'Ingo Molnar'" <mingo@redhat.com>,
linux-kernel@vger.kernel.org, "'Mike Galbraith'" <efault@gmx.de>,
"'Paul Turner'" <pjt@google.com>,
"'Alex Shi'" <alex.shi@intel.com>,
"'Vincent Guittot'" <vincent.guittot@linaro.org>,
"'Morten Rasmussen'" <morten.rasmussen@arm.com>,
"'Namhyung Kim'" <namhyung@kernel.org>,
"'Joonsoo Kim'" <js1304@gmail.com>
Subject: Re: [PATCH v2 2/3] sched: factor out code to should_we_balance()
Date: Fri, 2 Aug 2013 12:32:47 +0200 [thread overview]
Message-ID: <20130802103247.GL27162@twins.programming.kicks-ass.net> (raw)
In-Reply-To: <51FB7B36.8030909@linux.vnet.ibm.com>
On Fri, Aug 02, 2013 at 02:56:14PM +0530, Preeti U Murthy wrote:
> >> You need to iterate over all the groups of the sched domain env->sd and
> >> not just the first group of env->sd like you are doing above. This is to
> >
> > I don't think so.
> > IIRC, env->sd->groups always means local group,
> > so we don't need to find our group by iterating over all the groups.
>
> Take a look at update_sd_lb_stats(). That should clarify this. There is
> an exclusive
> local_group check there.
>
> sd->groups points to the first group in the list of groups under this sd.
Take a look at: 88b8dac0a
next prev parent reply other threads:[~2013-08-02 10:33 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 1:50 [PATCH v2 0/3] optimization, clean-up about fair.c Joonsoo Kim
2013-08-02 1:50 ` [PATCH v2 1/3] sched: remove one division operation in find_buiest_queue() Joonsoo Kim
2013-08-02 1:50 ` [PATCH v2 2/3] sched: factor out code to should_we_balance() Joonsoo Kim
2013-08-02 4:22 ` Preeti U Murthy
2013-08-02 9:05 ` 김준수
2013-08-02 9:26 ` Preeti U Murthy
2013-08-02 10:32 ` Peter Zijlstra [this message]
2013-08-05 4:22 ` Preeti U Murthy
2013-08-05 7:21 ` Joonsoo Kim
2013-08-02 10:20 ` Peter Zijlstra
2013-08-05 7:22 ` Joonsoo Kim
2013-08-02 7:51 ` Vincent Guittot
2013-08-02 9:08 ` Joonsoo Kim
2013-08-02 1:50 ` [PATCH v2 3/3] sched: clean-up struct sd_lb_stat Joonsoo Kim
2013-08-02 4:40 ` Preeti U Murthy
2013-08-05 7:32 ` Joonsoo Kim
2013-08-06 9:22 ` Preeti U Murthy
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802103247.GL27162@twins.programming.kicks-ass.net \
--to=peterz@infradead.org \
--cc=alex.shi@intel.com \
--cc=efault@gmx.de \
--cc=iamjoonsoo.kim@lge.com \
--cc=js1304@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@redhat.com \
--cc=morten.rasmussen@arm.com \
--cc=namhyung@kernel.org \
--cc=pjt@google.com \
--cc=preeti@linux.vnet.ibm.com \
--cc=vincent.guittot@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.