From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH] drm: const'ify ioctls table Date: Fri, 2 Aug 2013 13:51:32 +0300 Message-ID: <20130802105132.GK5004@intel.com> References: <1375381527-12708-1-git-send-email-robdclark@gmail.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga02.intel.com (mga02.intel.com [134.134.136.20]) by gabe.freedesktop.org (Postfix) with ESMTP id 43F97E65E2 for ; Fri, 2 Aug 2013 03:51:36 -0700 (PDT) Content-Disposition: inline In-Reply-To: <1375381527-12708-1-git-send-email-robdclark@gmail.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org To: Rob Clark Cc: dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org On Thu, Aug 01, 2013 at 02:25:27PM -0400, Rob Clark wrote: > Because, there is no reason for it not to be const. > = > Signed-off-by: Rob Clark > --- > diff --git a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c b/drivers/gpu/drm/vmwgfx= /vmwgfx_drv.c > index 78e2164..eaf86e0 100644 > --- a/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > +++ b/drivers/gpu/drm/vmwgfx/vmwgfx_drv.c > @@ -124,7 +124,7 @@ > * Ioctl definitions. > */ > = > -static struct drm_ioctl_desc vmw_ioctls[] =3D { > +static const struct drm_ioctl_desc vmw_ioctls[] =3D { > VMW_IOCTL_DEF(VMW_GET_PARAM, vmw_getparam_ioctl, > DRM_AUTH | DRM_UNLOCKED), > VMW_IOCTL_DEF(VMW_ALLOC_DMABUF, vmw_dmabuf_alloc_ioctl, You forgot to fix vmw_unlocked_ioctl(). Also if you're poking around this stuff, exynos and nouveau appear to set .num_ioctls from the probe/init funcs even though the ioctls array is right there in the same compilation unit. -- = Ville Syrj=E4l=E4 Intel OTC