All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 2 of 4] host-ccache: turn into a proper dependency
Date: Fri, 2 Aug 2013 10:52:42 +0200	[thread overview]
Message-ID: <20130802105242.123b40af@skate> (raw)
In-Reply-To: <CAHXCMM+DtuDr4OBq7e5zdj4+pQnu2uOXP9bj_COxt=hWkwre=w@mail.gmail.com>

Dear Samuel Martin,

On Fri, 2 Aug 2013 10:27:49 +0200, Samuel Martin wrote:

> > Note: this in itself works, when the dependencies are built (regular 'make'
> > for example, or explicit 'make dependencies'). However, if we want to
> > supersede patch http://patchwork.ozlabs.org/patch/257372/, that wants
> > the following to work:
> >
> > $ make clean menuconfig
> > $ make {barebox,busybox,ctng,linux,uclibc}-menuconfig
> >
> > then I think something additional is necessary. In the above flow, the
> > dependencies target is never used, so host-ccache doesn't get a chance to
> > build.
> Humm... I don't think so. This patch should be enough to fix the bug #5678.
> I mean, to run *-menuconfig, the package need to be extracted beforehand.
> I expect the 'dependencies' target is part of dependency list of the
> *-extract target (because of host-tar).

But it's not the case as far as I can see.

in busybox.mk:

busybox-menuconfig busybox-xconfig busybox-gconfig: busybox-patch

in pkg-generic.mk

$(1)-patch:             $(1)-extract $$($(2)_TARGET_PATCH)

$(1)-extract:           $(1)-source \
                        $$($(2)_TARGET_EXTRACT)

$(1)-source:            $$($(2)_TARGET_SOURCE)

and that's it. Nowhere it pulls 'dependencies' as far as I can see.

Thomas
-- 
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com

  parent reply	other threads:[~2013-08-02  8:52 UTC|newest]

Thread overview: 10+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-02  7:33 [Buildroot] [PATCH 0 of 4] ccache dependencies Thomas De Schampheleire
2013-08-02  7:33 ` [Buildroot] [PATCH 1 of 4] dependencies: build without ccache Thomas De Schampheleire
2013-08-02  7:33 ` [Buildroot] [PATCH 2 of 4] host-ccache: turn into a proper dependency Thomas De Schampheleire
2013-08-02  8:27   ` Samuel Martin
2013-08-02  8:45     ` Thomas De Schampheleire
2013-08-02  8:54       ` Samuel Martin
2013-08-07  9:28         ` Thomas De Schampheleire
2013-08-02  8:52     ` Thomas Petazzoni [this message]
2013-08-02  7:33 ` [Buildroot] [PATCH 3 of 4] crosstool-ng: remove unneed explicit ccache dependency Thomas De Schampheleire
2013-08-02  7:33 ` [Buildroot] [PATCH 4 of 4] sstrip: " Thomas De Schampheleire

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130802105242.123b40af@skate \
    --to=thomas.petazzoni@free-electrons.com \
    --cc=buildroot@busybox.net \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.