From: Thomas Petazzoni <thomas.petazzoni@free-electrons.com>
To: buildroot@busybox.net
Subject: [Buildroot] [PATCH 1 of 2 v2] infra: introduce suitable-extractor helper function
Date: Fri, 2 Aug 2013 10:56:33 +0200 [thread overview]
Message-ID: <20130802105633.0deb97c3@skate> (raw)
In-Reply-To: <CAAXf6LWFBKk2mebh8eVdhR1Epcauf5Lmk4CZLqgDV4Us+SX+GA@mail.gmail.com>
Dear Thomas De Schampheleire,
On Fri, 2 Aug 2013 10:50:44 +0200, Thomas De Schampheleire wrote:
> > Do you know why we need this $(firstword ...) call here? In all places
> > in was using directly $(INFLATE$(...)), except in the package
> > infrastructure where it was doing this firstword additional call.
> >
> > It was added by Peter in 2c6390a5d0c01420879e9f23bc89afb19976da4a.
>
> It wasn't clear to me when I sent the patch, but I figured it didn't hurt.
> But now I think I know: the inflate targets originate from the
> .config, and users can add extra arguments there. In fact, the default
> for $(ZCAT) is:
> BR2_ZCAT="gzip -d -c"
>
> To check the dependency, we only want to check for 'gzip', but to do
> the actual inflate, we shouldn't use 'firstword'. So, the patch is
> wrong, and I will fix it :)
Ok, makes sense to me now. Indeed this makes the patch wrong :)
Are you annoyed if I integrate this in -next ? I want to release -rc1
today, and I think this kind of stuff is a little bit too sensitive to
be merged now. From your quick feedback on those patches, I have the
feeling that you wanted it in 2013.08, so I don't want to ruin your
hope, but I believe it's a bit too late now. What do you think?
Best regards,
Thomas
--
Thomas Petazzoni, Free Electrons
Kernel, drivers, real-time and embedded Linux
development, consulting, training and support.
http://free-electrons.com
next prev parent reply other threads:[~2013-08-02 8:56 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 20:55 [Buildroot] [PATCH 0 of 2 v2] Introduce suitable-extractor and add host-xzcat dependency Thomas De Schampheleire
2013-08-01 20:55 ` [Buildroot] [PATCH 1 of 2 v2] infra: introduce suitable-extractor helper function Thomas De Schampheleire
2013-08-02 8:28 ` Thomas Petazzoni
2013-08-02 8:50 ` Thomas De Schampheleire
2013-08-02 8:56 ` Thomas Petazzoni [this message]
2013-08-02 9:02 ` Thomas De Schampheleire
2013-08-01 20:55 ` [Buildroot] [PATCH 2 of 2 v2] xzcat: treat as host prerequisite and build if needed Thomas De Schampheleire
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130802105633.0deb97c3@skate \
--to=thomas.petazzoni@free-electrons.com \
--cc=buildroot@busybox.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.