From mboxrd@z Thu Jan 1 00:00:00 1970 From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= Subject: Re: [PATCH 17/17] drm/i915: Add comments about units of latency values Date: Fri, 2 Aug 2013 19:09:31 +0300 Message-ID: <20130802160931.GO5004@intel.com> References: <1375363135-20618-1-git-send-email-ville.syrjala@linux.intel.com> <1375363135-20618-18-git-send-email-ville.syrjala@linux.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mga01.intel.com (mga01.intel.com [192.55.52.88]) by gabe.freedesktop.org (Postfix) with ESMTP id ACC06E63A5 for ; Fri, 2 Aug 2013 09:09:42 -0700 (PDT) Content-Disposition: inline In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org Errors-To: intel-gfx-bounces+gcfxdi-intel-gfx=m.gmane.org@lists.freedesktop.org To: Paulo Zanoni Cc: intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org On Fri, Aug 02, 2013 at 12:58:07PM -0300, Paulo Zanoni wrote: > 2013/8/1 : > > From: Ville Syrj=E4l=E4 > > > > All the ILK+ WM compute functions take the latency values in 0.1us > > units. Add a few comments to remind people about that. > > > > Signed-off-by: Ville Syrj=E4l=E4 > = > Reviewed-by: Paulo Zanoni > = > (but I would have written Latency instead of latency :P ) I was considering going for full blown kernel-doc, but since we don't currently generate docs for i915, i just used the name of the argument in question. > > --- > > drivers/gpu/drm/i915/intel_pm.c | 17 ++++++++++++++--- > > 1 file changed, 14 insertions(+), 3 deletions(-) > > > > diff --git a/drivers/gpu/drm/i915/intel_pm.c b/drivers/gpu/drm/i915/int= el_pm.c > > index 5fe8c4e..51f445f 100644 > > --- a/drivers/gpu/drm/i915/intel_pm.c > > +++ b/drivers/gpu/drm/i915/intel_pm.c > > @@ -2108,6 +2108,7 @@ static uint32_t ilk_pipe_pixel_rate(struct drm_de= vice *dev, > > return pixel_rate; > > } > > > > +/* latency must be in 0.1us units. */ > > static uint32_t ilk_wm_method1(uint32_t pixel_rate, uint8_t bytes_per_= pixel, > > uint32_t latency) > > { > > @@ -2122,6 +2123,7 @@ static uint32_t ilk_wm_method1(uint32_t pixel_rat= e, uint8_t bytes_per_pixel, > > return ret; > > } > > > > +/* latency must be in 0.1us units. */ > > static uint32_t ilk_wm_method2(uint32_t pixel_rate, uint32_t pipe_htot= al, > > uint32_t horiz_pixels, uint8_t bytes_per= _pixel, > > uint32_t latency) > > @@ -2185,7 +2187,10 @@ enum hsw_data_buf_partitioning { > > HSW_DATA_BUF_PART_5_6, > > }; > > > > -/* For both WM_PIPE and WM_LP. */ > > +/* > > + * For both WM_PIPE and WM_LP. > > + * mem_value must be in 0.1us units. > > + */ > > static uint32_t ilk_compute_pri_wm(struct hsw_pipe_wm_parameters *para= ms, > > uint32_t mem_value, > > bool is_lp) > > @@ -2212,7 +2217,10 @@ static uint32_t ilk_compute_pri_wm(struct hsw_pi= pe_wm_parameters *params, > > return min(method1, method2); > > } > > > > -/* For both WM_PIPE and WM_LP. */ > > +/* > > + * For both WM_PIPE and WM_LP. > > + * mem_value must be in 0.1us units. > > + */ > > static uint32_t ilk_compute_spr_wm(struct hsw_pipe_wm_parameters *para= ms, > > uint32_t mem_value) > > { > > @@ -2232,7 +2240,10 @@ static uint32_t ilk_compute_spr_wm(struct hsw_pi= pe_wm_parameters *params, > > return min(method1, method2); > > } > > > > -/* For both WM_PIPE and WM_LP. */ > > +/* > > + * For both WM_PIPE and WM_LP. > > + * mem_value must be in 0.1us units. > > + */ > > static uint32_t ilk_compute_cur_wm(struct hsw_pipe_wm_parameters *para= ms, > > uint32_t mem_value) > > { > > -- > > 1.8.1.5 > > > > _______________________________________________ > > Intel-gfx mailing list > > Intel-gfx@lists.freedesktop.org > > http://lists.freedesktop.org/mailman/listinfo/intel-gfx > = > = > = > -- = > Paulo Zanoni -- = Ville Syrj=E4l=E4 Intel OTC