From: Veaceslav Falico <vfalico@redhat.com>
To: nikolay@redhat.com
Cc: netdev@vger.kernel.org, davem@davemloft.net, fubar@us.ibm.com,
jhs@mojatatu.com
Subject: Re: [net] net_sched: make dev_trans_start return vlan's real dev trans_start
Date: Sat, 3 Aug 2013 19:07:33 +0200 [thread overview]
Message-ID: <20130803170733.GA10218@redhat.com> (raw)
In-Reply-To: <1375542471-22739-1-git-send-email-nikolay@redhat.com>
On Sat, Aug 03, 2013 at 05:07:51PM +0200, nikolay@redhat.com wrote:
...snip...
>+ while (is_vlan_dev(dev))
>+ dev = vlan_dev_real_dev(dev);
While at it - I've checked a few users (mainly network drivers) of
vlan_dev_real_dev(dev) and they all rely on that the return device would be
the *real* device, but not another vlan.
So maybe we should move this while loop to vlan_dev_real_dev() instead?
next prev parent reply other threads:[~2013-08-03 17:07 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-03 15:07 [PATCH net] net_sched: make dev_trans_start return vlan's real dev trans_start Nikolay Aleksandrov
2013-08-03 17:07 ` Veaceslav Falico [this message]
2013-08-03 18:13 ` [net] " Nikolay Aleksandrov
2013-08-03 18:19 ` Nikolay Aleksandrov
2013-08-03 18:25 ` Veaceslav Falico
2013-08-03 18:52 ` David Miller
2013-08-03 19:09 ` Veaceslav Falico
2013-08-03 19:35 ` Nikolay Aleksandrov
2013-08-03 19:37 ` David Miller
2013-08-03 19:37 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130803170733.GA10218@redhat.com \
--to=vfalico@redhat.com \
--cc=davem@davemloft.net \
--cc=fubar@us.ibm.com \
--cc=jhs@mojatatu.com \
--cc=netdev@vger.kernel.org \
--cc=nikolay@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.