From: Paul Mackerras <paulus@samba.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: Gleb Natapov <gleb@redhat.com>,
pbonzini@redhat.com, agraf@suse.de,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation
Date: Mon, 05 Aug 2013 04:34:06 +0000 [thread overview]
Message-ID: <20130805043406.GD19254@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <51ECD203.9050507@asianux.com>
On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote:
> 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when
> failure occurs, so it need a type cast for comparing.
>
> 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number
> when failure occurs, so it need a type cast for comparing.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Looks right, thanks.
Acked-by: Paul Mackerras <paulus@samba.org>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@samba.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: Gleb Natapov <gleb@redhat.com>,
kvm@vger.kernel.org, agraf@suse.de, kvm-ppc@vger.kernel.org,
pbonzini@redhat.com,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation
Date: Mon, 5 Aug 2013 14:34:06 +1000 [thread overview]
Message-ID: <20130805043406.GD19254@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <51ECD203.9050507@asianux.com>
On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote:
> 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when
> failure occurs, so it need a type cast for comparing.
>
> 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number
> when failure occurs, so it need a type cast for comparing.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Looks right, thanks.
Acked-by: Paul Mackerras <paulus@samba.org>
WARNING: multiple messages have this Message-ID (diff)
From: Paul Mackerras <paulus@samba.org>
To: Chen Gang <gang.chen@asianux.com>
Cc: Gleb Natapov <gleb@redhat.com>,
pbonzini@redhat.com, agraf@suse.de,
Benjamin Herrenschmidt <benh@kernel.crashing.org>,
kvm@vger.kernel.org, kvm-ppc@vger.kernel.org,
"linuxppc-dev@lists.ozlabs.org" <linuxppc-dev@lists.ozlabs.org>
Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation
Date: Mon, 5 Aug 2013 14:34:06 +1000 [thread overview]
Message-ID: <20130805043406.GD19254@iris.ozlabs.ibm.com> (raw)
In-Reply-To: <51ECD203.9050507@asianux.com>
On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote:
> 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when
> failure occurs, so it need a type cast for comparing.
>
> 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number
> when failure occurs, so it need a type cast for comparing.
>
>
> Signed-off-by: Chen Gang <gang.chen@asianux.com>
Looks right, thanks.
Acked-by: Paul Mackerras <paulus@samba.org>
next prev parent reply other threads:[~2013-08-05 4:34 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-22 6:32 [PATCH] arch: powerpc: kvm: add signed type cast for comparation Chen Gang
2013-07-22 6:32 ` Chen Gang
2013-07-22 6:32 ` Chen Gang
2013-07-30 2:56 ` Chen Gang
2013-07-30 2:56 ` Chen Gang
2013-07-30 2:56 ` Chen Gang
2013-08-05 4:34 ` Paul Mackerras [this message]
2013-08-05 4:34 ` Paul Mackerras
2013-08-05 4:34 ` Paul Mackerras
2013-08-05 5:50 ` Chen Gang
2013-08-05 5:50 ` Chen Gang
2013-08-05 5:50 ` Chen Gang
2013-08-28 14:24 ` Alexander Graf
2013-08-28 14:24 ` Alexander Graf
2013-08-28 14:24 ` Alexander Graf
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805043406.GD19254@iris.ozlabs.ibm.com \
--to=paulus@samba.org \
--cc=agraf@suse.de \
--cc=benh@kernel.crashing.org \
--cc=gang.chen@asianux.com \
--cc=gleb@redhat.com \
--cc=kvm-ppc@vger.kernel.org \
--cc=kvm@vger.kernel.org \
--cc=linuxppc-dev@lists.ozlabs.org \
--cc=pbonzini@redhat.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.