From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Date: Mon, 05 Aug 2013 04:34:06 +0000 Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation Message-Id: <20130805043406.GD19254@iris.ozlabs.ibm.com> List-Id: References: <51ECD203.9050507@asianux.com> In-Reply-To: <51ECD203.9050507@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Chen Gang Cc: Gleb Natapov , pbonzini@redhat.com, agraf@suse.de, Benjamin Herrenschmidt , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org" On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when > failure occurs, so it need a type cast for comparing. > > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number > when failure occurs, so it need a type cast for comparing. > > > Signed-off-by: Chen Gang Looks right, thanks. Acked-by: Paul Mackerras From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Date: Mon, 5 Aug 2013 14:34:06 +1000 From: Paul Mackerras To: Chen Gang Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation Message-ID: <20130805043406.GD19254@iris.ozlabs.ibm.com> References: <51ECD203.9050507@asianux.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii In-Reply-To: <51ECD203.9050507@asianux.com> Cc: Gleb Natapov , kvm@vger.kernel.org, agraf@suse.de, kvm-ppc@vger.kernel.org, pbonzini@redhat.com, "linuxppc-dev@lists.ozlabs.org" List-Id: Linux on PowerPC Developers Mail List List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when > failure occurs, so it need a type cast for comparing. > > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number > when failure occurs, so it need a type cast for comparing. > > > Signed-off-by: Chen Gang Looks right, thanks. Acked-by: Paul Mackerras From mboxrd@z Thu Jan 1 00:00:00 1970 From: Paul Mackerras Subject: Re: [PATCH] arch: powerpc: kvm: add signed type cast for comparation Date: Mon, 5 Aug 2013 14:34:06 +1000 Message-ID: <20130805043406.GD19254@iris.ozlabs.ibm.com> References: <51ECD203.9050507@asianux.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Cc: Gleb Natapov , pbonzini@redhat.com, agraf@suse.de, Benjamin Herrenschmidt , kvm@vger.kernel.org, kvm-ppc@vger.kernel.org, "linuxppc-dev@lists.ozlabs.org" To: Chen Gang Return-path: Content-Disposition: inline In-Reply-To: <51ECD203.9050507@asianux.com> Sender: kvm-ppc-owner@vger.kernel.org List-Id: kvm.vger.kernel.org On Mon, Jul 22, 2013 at 02:32:35PM +0800, Chen Gang wrote: > 'rmls' is 'unsigned long', lpcr_rmls() will return negative number when > failure occurs, so it need a type cast for comparing. > > 'lpid' is 'unsigned long', kvmppc_alloc_lpid() return negative number > when failure occurs, so it need a type cast for comparing. > > > Signed-off-by: Chen Gang Looks right, thanks. Acked-by: Paul Mackerras