From mboxrd@z Thu Jan  1 00:00:00 1970
Return-Path: <linux-kernel-owner@vger.kernel.org>
Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand
	id S1754394Ab3HEFZ7 (ORCPT <rfc822;w@1wt.eu>);
	Mon, 5 Aug 2013 01:25:59 -0400
Received: from mail.linuxfoundation.org ([140.211.169.12]:60982 "EHLO
	mail.linuxfoundation.org" rhost-flags-OK-OK-OK-OK) by vger.kernel.org
	with ESMTP id S1751280Ab3HEFZ6 (ORCPT
	<rfc822;linux-kernel@vger.kernel.org>);
	Mon, 5 Aug 2013 01:25:58 -0400
Date: Mon, 5 Aug 2013 13:27:15 +0800
From: Greg KH <gregkh@linuxfoundation.org>
To: "Winkler, Tomas" <tomas.winkler@intel.com>
Cc: "arnd@arndb.de" <arnd@arndb.de>,
        "linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
        Shuah Khan <shuah.kh@samsung.com>,
        Konstantin Khlebnikov <khlebnikov@openvz.org>
Subject: Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow
Message-ID: <20130805052715.GC31808@kroah.com>
References: <1375182711-10253-1-git-send-email-tomas.winkler@intel.com>
 <20130730142209.GA28956@kroah.com>
 <5B8DA87D05A7694D9FA63FD143655C1B1AE783C8@HASMSX106.ger.corp.intel.com>
MIME-Version: 1.0
Content-Type: text/plain; charset=us-ascii
Content-Disposition: inline
In-Reply-To: <5B8DA87D05A7694D9FA63FD143655C1B1AE783C8@HASMSX106.ger.corp.intel.com>
User-Agent: Mutt/1.5.21 (2010-09-15)
Sender: linux-kernel-owner@vger.kernel.org
List-ID: <linux-kernel.vger.kernel.org>
X-Mailing-List: linux-kernel@vger.kernel.org

On Tue, Jul 30, 2013 at 02:28:55PM +0000, Winkler, Tomas wrote:
> 
> > Subject: Re: [char-misc 3.11 V2] mei: me: fix hardware reset flow
> > 
> > On Tue, Jul 30, 2013 at 02:11:51PM +0300, Tomas Winkler wrote:
> > > Both H_IS and H_IE needs to be set to receive H_RDY interrupt
> > >
> > > 1. Assert H_IS to clear the interrupts during hw reset and use
> > > mei_me_reg_write instead of mei_hcsr_set as the later strips down the
> > > H_IS
> > >
> > > 2. fix interrupt disablement embarrassing typo
> > >   hcsr |= ~H_IE -> hcsr &= ~H_IE;
> > > this will remove the unwanted interrupt on power down
> > >
> > > 3. remove useless debug print outs
> > >
> > > Cc: Shuah Khan <shuah.kh@samsung.com>
> > > Cc: Konstantin Khlebnikov <khlebnikov@openvz.org>
> > > Signed-off-by: Tomas Winkler <tomas.winkler@intel.com>
> > > ---
> > >
> > > V2: Fixed typo in Shuah email
> > >
> > > Hope this finally resolve the ME reset issue for all
> > 
> > Can I get a "Tested-by:" from someone to ensure that it really does solve the
> > problem?
> 
> Yes,  please wait for ack/test results. It works for me but
> unfortunately I cannot go over all  9 gens of  PCH and all their
> proliferations  where ME resides. 
> I'm putting some effort to have better legacy HW testing coverage but I'm not there yet.

So what happened here with this patch, does it solve the reported
problems?

thanks,

greg k-h