From: Eli Cohen <eli@dev.mellanox.co.il>
To: David Miller <davem@davemloft.net>
Cc: dborkman@redhat.com, netdev@vger.kernel.org, ogerlitz@mellanox.com
Subject: Re: [PATCH net] net: mlx5: fix sizeof usage in health_care's reg_handler
Date: Mon, 5 Aug 2013 09:33:34 +0300 [thread overview]
Message-ID: <20130805063334.GA22386@mtldesk30> (raw)
In-Reply-To: <20130802.151132.539136654627638979.davem@davemloft.net>
On Fri, Aug 02, 2013 at 03:11:32PM -0700, David Miller wrote:
> From: Daniel Borkmann <dborkman@redhat.com>
> Date: Fri, 2 Aug 2013 12:16:17 +0200
>
> > Therefore, I strongly assume sizeof(*health->health) is being meant
> > to be passed as an argument. Interestingly, there are actually no
Daniel, you're fix is correct. I meant to pass the size of the struct
and not the size of the pointer.
> > in-tree users of mlx5_[un]register_health_report_handler(), but some
> > debugging modules might want to know the correct size instead.
>
> I want these hooks and infrastructure removed immediately.
>
> If there are no in-tree users there is no reason for them to
> exist at all.
>
Hi Dave,
the intention here was to allow other module, if they so wish, to get
notified of any problems detected at the device. I understand that you
don't like this but is there another way to handle this requirement
which will be accepted?
next prev parent reply other threads:[~2013-08-05 6:33 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 10:16 [PATCH net] net: mlx5: fix sizeof usage in health_care's reg_handler Daniel Borkmann
2013-08-02 22:11 ` David Miller
2013-08-02 22:43 ` Daniel Borkmann
2013-08-03 21:42 ` Or Gerlitz
2013-08-05 6:33 ` Eli Cohen [this message]
2013-08-05 6:39 ` David Miller
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805063334.GA22386@mtldesk30 \
--to=eli@dev.mellanox.co.il \
--cc=davem@davemloft.net \
--cc=dborkman@redhat.com \
--cc=netdev@vger.kernel.org \
--cc=ogerlitz@mellanox.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.