From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jean-Francois Moine Subject: Re: [PATCH RFC 06/13] ASoC: kirkwood: combine kirkwood-i2s and kirkwood-dma drivers Date: Mon, 5 Aug 2013 12:13:07 +0200 Message-ID: <20130805121307.555cb419@armhf> References: <20130804192136.GK23006@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=m.gmane.org@lists.infradead.org To: Russell King Cc: Thomas Petazzoni , Andrew Lunn , alsa-devel@alsa-project.org, Jason Cooper , Takashi Iwai , Liam Girdwood , Jaroslav Kysela , Mark Brown , linux-arm-kernel@lists.infradead.org List-Id: alsa-devel@alsa-project.org T24gU3VuLCAwNCBBdWcgMjAxMyAyMDoyNzowMyArMDEwMApSdXNzZWxsIEtpbmcgPHJtaytrZXJu ZWxAYXJtLmxpbnV4Lm9yZy51az4gd3JvdGU6Cgo+IFRoZXNlIHJlYWxseSBzaG91bGQgYmUgYSBz aW5nbGUgZHJpdmVyIGJlY2F1c2UgdGhleSdyZSBmdWxseSBpbnRlZ3JhdGVkCj4gaW4gaGFyZHdh cmUuICBNYWtlIHRoZW0gc28uCj4gCj4gU2lnbmVkLW9mZi1ieTogUnVzc2VsbCBLaW5nIDxybWsr a2VybmVsQGFybS5saW51eC5vcmcudWs+Cj4gLS0tCj4gIGFyY2gvYXJtL21hY2gtZG92ZS9jb21t b24uYyAgICAgICAgICB8ICAgIDQgKystLQo+ICBhcmNoL2FybS9tYWNoLWtpcmt3b29kL2NvbW1v bi5jICAgICAgfCAgIDI0ICsrKysrKysrKy0tLS0tLS0tLS0tLS0tLQo+ICBzb3VuZC9zb2Mva2ly a3dvb2QvS2NvbmZpZyAgICAgICAgICAgfCAgICA1IC0tLS0tCj4gIHNvdW5kL3NvYy9raXJrd29v ZC9NYWtlZmlsZSAgICAgICAgICB8ICAgIDQgKy0tLQo+ICBzb3VuZC9zb2Mva2lya3dvb2Qva2ly a3dvb2QtZG1hLmMgICAgfCAgIDMwICstLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLS0tLQo+ICBz b3VuZC9zb2Mva2lya3dvb2Qva2lya3dvb2QtaTJzLmMgICAgfCAgIDIxICsrKysrKysrKysrKysr KystLS0tLQo+ICBzb3VuZC9zb2Mva2lya3dvb2Qva2lya3dvb2Qtb3BlbnJkLmMgfCAgICA0ICsr LS0KPiAgc291bmQvc29jL2tpcmt3b29kL2tpcmt3b29kLXQ1MzI1LmMgIHwgICAgNCArKy0tCj4g IHNvdW5kL3NvYy9raXJrd29vZC9raXJrd29vZC5oICAgICAgICB8ICAgIDIgKysKPiAgOSBmaWxl cyBjaGFuZ2VkLCAzNSBpbnNlcnRpb25zKCspLCA2MyBkZWxldGlvbnMoLSkKCVtzbmlwXQoKR2xh ZCB0byBzZWUgeW91IGdvdCBteSBwYXRjaCwgYnV0IHdoeSBkaWQgeW91IGNoYW5nZWQgYWxsIHRo ZSBuYW1lcz8KClJlcGxhY2luZyAia2lya3dvb2QtcGNtLWF1ZGlvIiBieSAia2lya3dvb2QtaTJz IiBzaG91bGQgYmUgZW5vdWdoLgoKLS0gCktlbiBhciBjJ2hlbnRhw7EJfAkgICAgICAqKiBCcmVp emggaGEgTGludXggYXRhdiEgKioKSmVmCQl8CQlodHRwOi8vbW9pbmVqZi5mcmVlLmZyLwoKX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KbGludXgtYXJtLWtl cm5lbCBtYWlsaW5nIGxpc3QKbGludXgtYXJtLWtlcm5lbEBsaXN0cy5pbmZyYWRlYWQub3JnCmh0 dHA6Ly9saXN0cy5pbmZyYWRlYWQub3JnL21haWxtYW4vbGlzdGluZm8vbGludXgtYXJtLWtlcm5l bAo= From mboxrd@z Thu Jan 1 00:00:00 1970 From: moinejf@free.fr (Jean-Francois Moine) Date: Mon, 5 Aug 2013 12:13:07 +0200 Subject: [PATCH RFC 06/13] ASoC: kirkwood: combine kirkwood-i2s and kirkwood-dma drivers In-Reply-To: References: <20130804192136.GK23006@n2100.arm.linux.org.uk> Message-ID: <20130805121307.555cb419@armhf> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org On Sun, 04 Aug 2013 20:27:03 +0100 Russell King wrote: > These really should be a single driver because they're fully integrated > in hardware. Make them so. > > Signed-off-by: Russell King > --- > arch/arm/mach-dove/common.c | 4 ++-- > arch/arm/mach-kirkwood/common.c | 24 +++++++++--------------- > sound/soc/kirkwood/Kconfig | 5 ----- > sound/soc/kirkwood/Makefile | 4 +--- > sound/soc/kirkwood/kirkwood-dma.c | 30 +----------------------------- > sound/soc/kirkwood/kirkwood-i2s.c | 21 ++++++++++++++++----- > sound/soc/kirkwood/kirkwood-openrd.c | 4 ++-- > sound/soc/kirkwood/kirkwood-t5325.c | 4 ++-- > sound/soc/kirkwood/kirkwood.h | 2 ++ > 9 files changed, 35 insertions(+), 63 deletions(-) [snip] Glad to see you got my patch, but why did you changed all the names? Replacing "kirkwood-pcm-audio" by "kirkwood-i2s" should be enough. -- Ken ar c'henta? | ** Breizh ha Linux atav! ** Jef | http://moinejf.free.fr/