From: majianpeng <majianpeng@gmail.com>
To: sage <sage@inktank.com>
Cc: ceph-devel <ceph-devel@vger.kernel.org>
Subject: Re: Re: [PATCH 2/2] ceph: Add pg_name filed in struct ceph_ioctl_dataloc.
Date: Mon, 5 Aug 2013 13:27:56 +0800 [thread overview]
Message-ID: <2013080513275334267212@gmail.com> (raw)
In-Reply-To: alpine.DEB.2.00.1308042117030.5645@cobra.newdream.net
>On Mon, 5 Aug 2013, majianpeng wrote:
>> As the 'ceph help' print, it will print pgs.But now it can't.
>> So we add this.There are two type name of pg, temp and stable.
>> Because the command 'ceph pg dump' print temp name,so we also print the
>> temp name of pg.
>
>Unfortunately we can't modify the ioctl structure like this without
>breaking the kernel/userspace ABI (a big no-no). The usual way around
>that is to make a new ioctl (like CEPH_IOC_GET_DATALOC2) and a new
>structure (struct ceph_ioctl_dataloc2) with the additional fields.
>
>What is this going to be used for? You can get the full info from the
>montior with the 'ceph osd map <pool name> <object name> --format=json'.
>Does it need to come from the kernel this way?
>
I only want to print the pgid when print other infos using cephfs map or sho_location.
I'll dig into the implementation of 'ceph osd map <pool name> <object name> --format=json'.
Thanks!
Jianpeng Ma
prev parent reply other threads:[~2013-08-05 5:28 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 2:51 [PATCH 2/2] ceph: Add pg_name filed in struct ceph_ioctl_dataloc majianpeng
2013-08-05 4:24 ` Sage Weil
2013-08-05 5:27 ` majianpeng [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=2013080513275334267212@gmail.com \
--to=majianpeng@gmail.com \
--cc=ceph-devel@vger.kernel.org \
--cc=sage@inktank.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.