From: Gleb Natapov <gleb@redhat.com>
To: Ralf Baechle <ralf@linux-mips.org>
Cc: James Hogan <james.hogan@imgtec.com>,
David Daney <ddaney.cavm@gmail.com>,
linux-mips@linux-mips.org, kvm@vger.kernel.org,
Sanjay Lal <sanjayl@kymasys.com>,
linux-kernel@vger.kernel.org,
David Daney <david.daney@cavium.com>
Subject: Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S
Date: Mon, 5 Aug 2013 16:43:27 +0300 [thread overview]
Message-ID: <20130805134326.GA15901@redhat.com> (raw)
In-Reply-To: <20130805132157.GB3470@linux-mips.org>
On Mon, Aug 05, 2013 at 03:21:57PM +0200, Ralf Baechle wrote:
> On Mon, Aug 05, 2013 at 02:17:01PM +0100, James Hogan wrote:
>
> >
> > On 01/08/13 21:22, David Daney wrote:
> > > From: David Daney <david.daney@cavium.com>
> > >
> > > No code changes, just reflowing some comments and consistently using
> > > tabs and spaces. Object code is verified to be unchanged.
> > >
> > > Signed-off-by: David Daney <david.daney@cavium.com>
> > > Acked-by: Ralf Baechle <ralf@linux-mips.org>
> >
> >
> > > + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */
> >
> > git am detects a whitespace error here ("space before tab in indent").
> > It's got spaces before and after the tab actually.
> >
> > > /* load the guest context from VCPU and return */
> >
> > this comment could have it's indentation fixed too
> >
> > Otherwise, for all 3 patches:
> >
> > Reviewed-by: James Hogan <james.hogan@imgtec.com>
>
> I'm happy with the patch series as well and will fix this issue when
> applying the patch.
>
kvm fixes usually go through kvm.git tree for all arches. Any special
reasons you want to get those through mips tree?
--
Gleb.
next prev parent reply other threads:[~2013-08-05 13:43 UTC|newest]
Thread overview: 13+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-01 20:22 [PATCH 0/3] mips/kvm: Code cleanups for kvm_locore.S David Daney
2013-08-01 20:22 ` [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S David Daney
2013-08-05 13:17 ` James Hogan
2013-08-05 13:17 ` James Hogan
2013-08-05 13:21 ` Ralf Baechle
2013-08-05 13:43 ` Gleb Natapov [this message]
2013-08-05 16:52 ` David Daney
2013-08-05 16:52 ` David Daney
2013-08-05 17:06 ` Ralf Baechle
2013-08-05 17:22 ` Gleb Natapov
2013-08-01 20:22 ` [PATCH 2/3] mips/kvm: Cleanup .push/.pop directives in kvm_locore.S David Daney
2013-08-01 20:22 ` [PATCH 3/3] mips/kvm: Make kvm_locore.S 64-bit buildable/safe David Daney
2013-08-09 11:50 ` [PATCH 0/3] mips/kvm: Code cleanups for kvm_locore.S Paolo Bonzini
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130805134326.GA15901@redhat.com \
--to=gleb@redhat.com \
--cc=david.daney@cavium.com \
--cc=ddaney.cavm@gmail.com \
--cc=james.hogan@imgtec.com \
--cc=kvm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mips@linux-mips.org \
--cc=ralf@linux-mips.org \
--cc=sanjayl@kymasys.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.