From mboxrd@z Thu Jan 1 00:00:00 1970 Received: with ECARTIS (v1.0.0; list linux-mips); Mon, 05 Aug 2013 19:06:24 +0200 (CEST) Received: from localhost.localdomain ([127.0.0.1]:50048 "EHLO linux-mips.org" rhost-flags-OK-OK-OK-FAIL) by eddie.linux-mips.org with ESMTP id S6824790Ab3HERGTmpBB- (ORCPT ); Mon, 5 Aug 2013 19:06:19 +0200 Received: from scotty.linux-mips.net (localhost.localdomain [127.0.0.1]) by scotty.linux-mips.net (8.14.5/8.14.4) with ESMTP id r75H6EDw018999; Mon, 5 Aug 2013 19:06:14 +0200 Received: (from ralf@localhost) by scotty.linux-mips.net (8.14.5/8.14.5/Submit) id r75H6B8c018998; Mon, 5 Aug 2013 19:06:11 +0200 Date: Mon, 5 Aug 2013 19:06:10 +0200 From: Ralf Baechle To: Gleb Natapov Cc: James Hogan , David Daney , linux-mips@linux-mips.org, kvm@vger.kernel.org, Sanjay Lal , linux-kernel@vger.kernel.org, David Daney Subject: Re: [PATCH 1/3] mips/kvm: Improve code formatting in arch/mips/kvm/kvm_locore.S Message-ID: <20130805170610.GA17633@linux-mips.org> References: <1375388555-4045-1-git-send-email-ddaney.cavm@gmail.com> <1375388555-4045-2-git-send-email-ddaney.cavm@gmail.com> <51FFA5CD.3010406@imgtec.com> <20130805132157.GB3470@linux-mips.org> <20130805134326.GA15901@redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130805134326.GA15901@redhat.com> User-Agent: Mutt/1.5.21 (2010-09-15) Return-Path: X-Envelope-To: <"|/home/ecartis/ecartis -s linux-mips"> (uid 0) X-Orcpt: rfc822;linux-mips@linux-mips.org Original-Recipient: rfc822;linux-mips@linux-mips.org X-archive-position: 37433 X-ecartis-version: Ecartis v1.0.0 Sender: linux-mips-bounce@linux-mips.org Errors-to: linux-mips-bounce@linux-mips.org X-original-sender: ralf@linux-mips.org Precedence: bulk List-help: List-unsubscribe: List-software: Ecartis version 1.0.0 List-Id: linux-mips X-List-ID: linux-mips List-subscribe: List-owner: List-post: List-archive: X-list: linux-mips On Mon, Aug 05, 2013 at 04:43:27PM +0300, Gleb Natapov wrote: > Date: Mon, 5 Aug 2013 16:43:27 +0300 > From: Gleb Natapov > To: Ralf Baechle > Cc: James Hogan , David Daney > , linux-mips@linux-mips.org, kvm@vger.kernel.org, > Sanjay Lal , linux-kernel@vger.kernel.org, David > Daney > Subject: Re: [PATCH 1/3] mips/kvm: Improve code formatting in > arch/mips/kvm/kvm_locore.S > Content-Type: text/plain; charset=us-ascii > > On Mon, Aug 05, 2013 at 03:21:57PM +0200, Ralf Baechle wrote: > > On Mon, Aug 05, 2013 at 02:17:01PM +0100, James Hogan wrote: > > > > > > > > On 01/08/13 21:22, David Daney wrote: > > > > From: David Daney > > > > > > > > No code changes, just reflowing some comments and consistently using > > > > tabs and spaces. Object code is verified to be unchanged. > > > > > > > > Signed-off-by: David Daney > > > > Acked-by: Ralf Baechle > > > > > > > > > > + /* Put the saved pointer to vcpu (s1) back into the DDATA_LO Register */ > > > > > > git am detects a whitespace error here ("space before tab in indent"). > > > It's got spaces before and after the tab actually. > > > > > > > /* load the guest context from VCPU and return */ > > > > > > this comment could have it's indentation fixed too > > > > > > Otherwise, for all 3 patches: > > > > > > Reviewed-by: James Hogan > > > > I'm happy with the patch series as well and will fix this issue when > > applying the patch. > > > kvm fixes usually go through kvm.git tree for all arches. Any special > reasons you want to get those through mips tree? MIPS fixes usually go through the MIPS tree ;-) I don't care which tree this stuff goes through - but a general experience is that things that affect MIPS systems receive most testing if going through the MIPS tree. Ralf