All of lore.kernel.org
 help / color / mirror / Atom feed
From: Anton Blanchard <anton@samba.org>
To: Randy Dunlap <rdunlap@infradead.org>
Cc: linux-scsi@vger.kernel.org, james.smart@emulex.com,
	JBottomley@parallels.com
Subject: Why does lpfc select GENERIC_CSUM?
Date: Mon, 5 Aug 2013 20:20:17 +1000	[thread overview]
Message-ID: <20130805202017.651b6cfd@kryten> (raw)


Hi Randy,

commit 6a7252fd ([SCSI] lpfc: fix up Kconfig dependencies) added a
select of GENERIC_CSUM. This seems strange to me - it's an architecture
specific detail if the checksum routines are implemented in assembly or
if they pull in lib/checksum.c.

The networking code doesn't select GENERIC_CSUM, so I'm not sure why
the lpfc driver needs to. Was there a real issue we hit here?

Regards,
Anton

             reply	other threads:[~2013-08-05 10:20 UTC|newest]

Thread overview: 4+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-05 10:20 Anton Blanchard [this message]
2013-08-07 22:25 ` Why does lpfc select GENERIC_CSUM? Randy Dunlap
2013-08-08  7:47   ` [SCSI] lpfc: Don't force CONFIG_GENERIC_CSUM on Anton Blanchard
2013-08-08 15:01     ` James Smart

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130805202017.651b6cfd@kryten \
    --to=anton@samba.org \
    --cc=JBottomley@parallels.com \
    --cc=james.smart@emulex.com \
    --cc=linux-scsi@vger.kernel.org \
    --cc=rdunlap@infradead.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.