From: Andi Kleen <andi@firstfloor.org>
To: Andrew Morton <akpm@linux-foundation.org>
Cc: Andi Kleen <andi@firstfloor.org>,
viro@zeniv.linux.org.uk, linux-kernel@vger.kernel.org,
Andi Kleen <ak@linux.intel.com>
Subject: Re: [PATCH] Use gcc alias instead of assembler aliases for syscalls
Date: Tue, 6 Aug 2013 08:42:01 +0200 [thread overview]
Message-ID: <20130806064201.GR19750@two.firstfloor.org> (raw)
In-Reply-To: <20130805225949.82a82dda.akpm@linux-foundation.org>
On Mon, Aug 05, 2013 at 10:59:49PM -0700, Andrew Morton wrote:
> On Mon, 5 Aug 2013 15:09:35 -0700 Andi Kleen <andi@firstfloor.org> wrote:
>
> > From: Andi Kleen <ak@linux.intel.com>
> >
> > Use standard gcc __attribute__((alias(foo))) to define
> > the syscall aliases instead of custom assembler macros.
> >
> > This is far cleaner, and also fixes my LTO kernel build.
>
> I wonder what gcc version this was added in. Seems fairly longstanding.
Seems to be already in 2.95, so every kernel compiler
http://gcc.gnu.org/onlinedocs/gcc-2.95.3/gcc_4.html#SEC90
>
> > { \
> > return C_SYSC##name(__MAP(x,__SC_DELOUSE,__VA_ARGS__)); \
> > } \
> > - SYSCALL_ALIAS(compat_sys##name, compat_SyS##name); \
>
> I think we can remove the SYSCALL_ALIAS definitions?
Yes will send a followon patch.
-Andi
--
ak@linux.intel.com -- Speaking for myself only.
next prev parent reply other threads:[~2013-08-06 6:42 UTC|newest]
Thread overview: 6+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 22:09 [PATCH] Use gcc alias instead of assembler aliases for syscalls Andi Kleen
2013-08-06 5:59 ` Andrew Morton
2013-08-06 6:42 ` Andi Kleen [this message]
2013-08-06 7:40 ` Al Viro
2013-08-07 23:54 ` Andrew Morton
2013-08-08 4:39 ` Andi Kleen
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130806064201.GR19750@two.firstfloor.org \
--to=andi@firstfloor.org \
--cc=ak@linux.intel.com \
--cc=akpm@linux-foundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=viro@zeniv.linux.org.uk \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.