From: Benjamin LaHaise <bcrl@kvack.org>
To: Peng Tao <bergwolf@gmail.com>
Cc: linux-kernel@vger.kernel.org, Peng Tao <tao.peng@emc.com>,
Kent Overstreet <koverstreet@google.com>,
Andreas Dilger <andreas.dilger@intel.com>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
linux-aio@kvack.org
Subject: Re: [PATCH] staging/lustre: kiocb->ki_left is removed
Date: Tue, 6 Aug 2013 11:03:08 -0400 [thread overview]
Message-ID: <20130806150308.GB8043@kvack.org> (raw)
In-Reply-To: <1375792261-2674-1-git-send-email-bergwolf@gmail.com>
On Tue, Aug 06, 2013 at 08:31:01PM +0800, Peng Tao wrote:
> From: Peng Tao <tao.peng@emc.com>
>
> We also missed ki_nbytes...
Applied to the aio-next.git tree.
-ben
> Cc: Kent Overstreet <koverstreet@google.com>
> Cc: Andreas Dilger <andreas.dilger@intel.com>
> Cc: Greg Kroah-Hartman <gregkh@linuxfoundation.org>
> Signed-off-by: Peng Tao <tao.peng@emc.com>
> ---
> This fixes Lustre build in linux-next and needs to go through
> the aio tree as Kent's AIO patch is not in upstream kernel.
>
> drivers/staging/lustre/lustre/llite/file.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
>
> diff --git a/drivers/staging/lustre/lustre/llite/file.c b/drivers/staging/lustre/lustre/llite/file.c
> index 253f026..bc534db 100644
> --- a/drivers/staging/lustre/lustre/llite/file.c
> +++ b/drivers/staging/lustre/lustre/llite/file.c
> @@ -1009,7 +1009,7 @@ static ssize_t ll_file_read(struct file *file, char *buf, size_t count,
> local_iov->iov_len = count;
> init_sync_kiocb(kiocb, file);
> kiocb->ki_pos = *ppos;
> - kiocb->ki_left = count;
> + kiocb->ki_nbytes = count;
>
> result = ll_file_aio_read(kiocb, local_iov, 1, kiocb->ki_pos);
> *ppos = kiocb->ki_pos;
> @@ -1068,7 +1068,7 @@ static ssize_t ll_file_write(struct file *file, const char *buf, size_t count,
> local_iov->iov_len = count;
> init_sync_kiocb(kiocb, file);
> kiocb->ki_pos = *ppos;
> - kiocb->ki_left = count;
> + kiocb->ki_nbytes = count;
>
> result = ll_file_aio_write(kiocb, local_iov, 1, kiocb->ki_pos);
> *ppos = kiocb->ki_pos;
> --
> 1.7.9.5
--
"Thought is the essence of where you are now."
next prev parent reply other threads:[~2013-08-06 15:03 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 12:31 [PATCH] staging/lustre: kiocb->ki_left is removed Peng Tao
2013-08-06 15:03 ` Benjamin LaHaise [this message]
2013-08-07 6:06 ` Christoph Hellwig
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130806150308.GB8043@kvack.org \
--to=bcrl@kvack.org \
--cc=andreas.dilger@intel.com \
--cc=bergwolf@gmail.com \
--cc=gregkh@linuxfoundation.org \
--cc=koverstreet@google.com \
--cc=linux-aio@kvack.org \
--cc=linux-kernel@vger.kernel.org \
--cc=tao.peng@emc.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.