All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfgang Denk <wd@denx.de>
To: u-boot@lists.denx.de
Subject: [U-Boot] [RESEND PATCH v2 08/20] sf: probe: Add support for S25FL* flash parts
Date: Tue, 06 Aug 2013 22:05:29 +0200	[thread overview]
Message-ID: <20130806200529.EBAEE380DF0@gemini.denx.de> (raw)
In-Reply-To: <64c2a6cb-98f6-4cde-a615-ecd37a96b6ea@DB8EHSMHS012.ehs.local>

Dear Jagan,

In message <64c2a6cb-98f6-4cde-a615-ecd37a96b6ea@DB8EHSMHS012.ehs.local> you wrote:
>
> > Checkpatch reports:
> >
> > WARNING: quoted string split across lines
> > #194: FILE: drivers/mtd/spi/spi_flash_probe.c:155:
> > +               printf("SF: Unsupported flash ID: manuf %02x, jedec %04x "
> > +                      "ext_jedec %04x\n", idcode[0], jedec, ext_jedec);
> 
> Yes I knew this.
> Any better way we handle " quoted string split across lines" w.r.t recent codes.
> Request for suggestion.

Well, do not split the string.

Best regards,

Wolfgang Denk

-- 
DENX Software Engineering GmbH,     MD: Wolfgang Denk & Detlev Zundel
HRB 165235 Munich, Office: Kirchenstr.5, D-82194 Groebenzell, Germany
Phone: (+49)-8142-66989-10 Fax: (+49)-8142-66989-80 Email: wd at denx.de
Nobody goes to that restaurant anymore. It's too crowded.

  parent reply	other threads:[~2013-08-06 20:05 UTC|newest]

Thread overview: 23+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
     [not found] <1375805851-32163-1-git-send-email-jaganna@xilinx.com>
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 01/20] sf: Divide spi_flash into multiple parts Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 02/20] sf: probe: Add new spi_flash_probe support Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 03/20] sf: probe: Add support for M25P* flash parts Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 04/20] sf: probe: Add support for EN25Q* " Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 05/20] sf: probe: Add support for GD25* " Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 06/20] sf: probe: Add support for MX25L* " Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 07/20] sf: probe: Add support for W25* " Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 08/20] sf: probe: Add support for S25FL* " Jagannadha Sutradharudu Teki
2013-08-06 19:49   ` Wolfgang Denk
2013-08-06 19:54     ` Jagan Teki
     [not found]     ` <64c2a6cb-98f6-4cde-a615-ecd37a96b6ea@DB8EHSMHS012.ehs.local>
2013-08-06 20:05       ` Wolfgang Denk [this message]
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 09/20] sf: probe: Add support for SST25* " Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 10/20] sf: probe: Add support for AT45DB* " Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 11/20] sf: probe: Give proper spacing on flash table params Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 12/20] sf: probe: Add support for SST_WP Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 13/20] sf: probe: Add support to clear flash BP# bits Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 14/20] sf: probe: Add support for erase sector selection flag Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 15/20] sf: probe: Add support for flag status polling Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 16/20] sf: probe: Move BAR config to spi_flash_validate_ids Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 17/20] sf: Add proper comment style on spi_flash structure Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 18/20] sf: ramtron: Add support for separate flash driver Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 19/20] sf: Remove unneeded flash drivers files Jagannadha Sutradharudu Teki
2013-08-06 16:17 ` [U-Boot] [RESEND PATCH v2 20/20] sf: probe: Add support for EN25Q64 Jagannadha Sutradharudu Teki

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130806200529.EBAEE380DF0@gemini.denx.de \
    --to=wd@denx.de \
    --cc=u-boot@lists.denx.de \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.