From mboxrd@z Thu Jan 1 00:00:00 1970 From: Greg Kroah-Hartman Subject: Re: [PATCH 1/5] pdev: Fix platform device resource linking Date: Wed, 7 Aug 2013 14:57:00 +0900 Message-ID: <20130807055700.GD5304@kroah.com> References: <1375775624-12250-1-git-send-email-panto@antoniou-consulting.com> <1375775624-12250-2-git-send-email-panto@antoniou-consulting.com> <20130806093601.GB27889@kroah.com> <311C42C3-6544-4058-ABE9-F9FAE72DD5CA@antoniou-consulting.com> <20130806101527.GB29283@kroah.com> <20130806101914.GH23053@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Return-path: Content-Disposition: inline In-Reply-To: <20130806101914.GH23053@n2100.arm.linux.org.uk> Sender: linux-kernel-owner@vger.kernel.org To: Russell King - ARM Linux Cc: Pantelis Antoniou , Tony Lindgren , =?iso-8859-1?Q?Beno=EEt?= Coussno , Paul Walmsley , Sourav Poddar , Russ Dill , Felipe Balbi , Koen Kooi , linux-omap@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: linux-omap@vger.kernel.org On Tue, Aug 06, 2013 at 11:19:14AM +0100, Russell King - ARM Linux wrote: > On Tue, Aug 06, 2013 at 06:15:27PM +0800, Greg Kroah-Hartman wrote: > > On Tue, Aug 06, 2013 at 12:45:42PM +0300, Pantelis Antoniou wrote: > > > What would it take to move all this into driver core? > > > > What specifically would you move into there? > > A variable to hold the streaming dma_mask, so that its in struct device > rather than having to be separate. Yes, we can keep the pointer in there > too, because that appears to convey meaning in the kernel today - whether > the device can do DMA or not. > > A NULL dma_mask pointer already means it can't and dma_set_mask() always > fails. A non-NULL dma_mask pointer means the driver can use > dma_set_mask() to set an appropriate mask. Ok, that sounds fine to me, for some reason I thought I said yes to this a long time ago, did no one ever send me a patch for it? thanks, greg k-h