From: Lee Jones <lee.jones@linaro.org>
To: Zubair Lutfullah <zubair.lutfullah@gmail.com>
Cc: sameo@linux.intel.com, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org, bigeasy@linutronix.de
Subject: Re: [PATCH] mfd: ti_am335x_tscadc: fix spin lock and reg_cache
Date: Wed, 7 Aug 2013 09:40:54 +0100 [thread overview]
Message-ID: <20130807084054.GA18668@lee--X1> (raw)
In-Reply-To: <1375729845-6992-1-git-send-email-zubair.lutfullah@gmail.com>
On Mon, 05 Aug 2013, Zubair Lutfullah wrote:
> Reg_cache variable is used to lock step enable register
> from being accessed and written by both TSC and ADC
> at the same time.
> However, it isn't updated anywhere in the code at all.
>
> If both TSC and ADC are used, eventually 1FFFF is always
> written enabling all 16 steps uselessly causing a mess.
>
> Patch fixes it by correcting the locks and updates the
> variable by reading the step enable register
>
> Signed-off-by: Zubair Lutfullah <zubair.lutfullah@gmail.com>
> ---
> drivers/mfd/ti_am335x_tscadc.c | 4 ++--
> 1 file changed, 2 insertions(+), 2 deletions(-)
Better that it comes from somewhere.
Applied, thanks.
--
Lee Jones
Linaro ST-Ericsson Landing Team Lead
Linaro.org │ Open source software for ARM SoCs
Follow Linaro: Facebook | Twitter | Blog
next prev parent reply other threads:[~2013-08-07 8:41 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-05 19:10 [PATCH] mfd: ti_am335x_tscadc: fix spin lock and reg_cache Zubair Lutfullah
2013-08-07 8:40 ` Lee Jones [this message]
2013-10-22 13:15 ` Sebastian Andrzej Siewior
2013-10-22 15:48 ` Lee Jones
2013-10-22 16:28 ` Sebastian Andrzej Siewior
2013-10-25 15:53 ` Zubair Lutfullah :
2013-10-22 16:05 ` Lee Jones
2013-10-22 16:38 ` Sebastian Andrzej Siewior
2013-10-22 17:06 ` Lee Jones
2013-10-22 17:17 ` Sebastian Andrzej Siewior
2013-10-22 17:36 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807084054.GA18668@lee--X1 \
--to=lee.jones@linaro.org \
--cc=bigeasy@linutronix.de \
--cc=gregkh@linuxfoundation.org \
--cc=linux-kernel@vger.kernel.org \
--cc=sameo@linux.intel.com \
--cc=zubair.lutfullah@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.