From mboxrd@z Thu Jan  1 00:00:00 1970
From: Ville =?iso-8859-1?Q?Syrj=E4l=E4?= <ville.syrjala@linux.intel.com>
Subject: Re: [PATCH v2] drm: use ida to allocate connector ids
Date: Wed, 7 Aug 2013 13:47:54 +0300
Message-ID: <20130807104754.GS5004@intel.com>
References: <1375168611-3384-1-git-send-email-imirkin@alum.mit.edu>
	<1375170709-4355-1-git-send-email-imirkin@alum.mit.edu>
	<20130807080014.GO5004@intel.com>
	<CAKb7UvjVxTYy_JOYppUnFT4hzrqgmdJ6bsMBTHp7LMt-9Z923Q@mail.gmail.com>
Mime-Version: 1.0
Content-Type: text/plain; charset="iso-8859-1"
Content-Transfer-Encoding: quoted-printable
Return-path: <dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org>
Received: from mga09.intel.com (mga09.intel.com [134.134.136.24])
	by gabe.freedesktop.org (Postfix) with ESMTP id E7D3AE62C4
	for <dri-devel@lists.freedesktop.org>;
	Wed,  7 Aug 2013 03:47:59 -0700 (PDT)
Content-Disposition: inline
In-Reply-To: <CAKb7UvjVxTYy_JOYppUnFT4hzrqgmdJ6bsMBTHp7LMt-9Z923Q@mail.gmail.com>
List-Unsubscribe: <http://lists.freedesktop.org/mailman/options/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=unsubscribe>
List-Archive: <http://lists.freedesktop.org/archives/dri-devel>
List-Post: <mailto:dri-devel@lists.freedesktop.org>
List-Help: <mailto:dri-devel-request@lists.freedesktop.org?subject=help>
List-Subscribe: <http://lists.freedesktop.org/mailman/listinfo/dri-devel>,
	<mailto:dri-devel-request@lists.freedesktop.org?subject=subscribe>
Sender: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
Errors-To: dri-devel-bounces+sf-dri-devel=m.gmane.org@lists.freedesktop.org
To: Ilia Mirkin <imirkin@alum.mit.edu>
Cc: dri-devel@lists.freedesktop.org
List-Id: dri-devel@lists.freedesktop.org

On Wed, Aug 07, 2013 at 04:28:35AM -0400, Ilia Mirkin wrote:
> On Wed, Aug 7, 2013 at 4:00 AM, Ville Syrj=E4l=E4
> <ville.syrjala@linux.intel.com> wrote:
> > On Tue, Jul 30, 2013 at 03:51:49AM -0400, Ilia Mirkin wrote:
> >> @@ -722,8 +741,9 @@ int drm_connector_init(struct drm_device *dev,
> >>       connector->dev =3D dev;
> >>       connector->funcs =3D funcs;
> >>       connector->connector_type =3D connector_type;
> >> -     connector->connector_type_id =3D
> >> -             ++drm_connector_enum_list[connector_type].count; /* TODO=
 */
> >> +     ret =3D ida_get_new_above(count, 1, &connector->connector_type_i=
d);
> >> +     if (ret)
> >> +             goto out;
> >
> > Leak.
> =

> I assume this is in reference to the drm_mode_object_get above? I just
> noticed that... or was there something else too?

Just the obj id.

-- =

Ville Syrj=E4l=E4
Intel OTC