All of lore.kernel.org
 help / color / mirror / Atom feed
From: Wolfram Sang <wsa-z923LK4zBo2bacvFa/9K2g@public.gmane.org>
To: James Lebron <leileishangchina-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org>
Cc: Leilei Shang <shangll-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>,
	linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org
Subject: Re: [PATCH] i2c: pxa: enable high speed mode for i2c bus
Date: Wed, 7 Aug 2013 15:55:39 +0200	[thread overview]
Message-ID: <20130807135538.GA2978@katana> (raw)
In-Reply-To: <CAOng1WTa0c2Jb9yPeynKXQ0K4-bPhrcGPsKd-AP-MuxQPH80Jg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>

[-- Attachment #1: Type: text/plain, Size: 756 bytes --]

On Tue, Jul 02, 2013 at 10:10:29AM +0800, James Lebron wrote:
> Hi Wolfram
> 
>     Have you finished reading datasheet?

Sadly not. I couldn't find the reference manual freely available. That
was a problem when reviewing this patch.

> 1. High speed mode is hardware feature, you can't read it from
> software. It's similar to fast mode, and fast mode is set in platform
> data.

Yes, setting fast mode in platform_data is troublesome, too. Better
would be to introduce a new platform_id (say, pxa910-i2c) and to deduce
from that id that only this version has high speed mode. I am accepting
the current solution since it is consistent with fast mode, but all this
needs to be fixed if pxa is going devicetree.

Thanks,

   Wolfram


[-- Attachment #2: Digital signature --]
[-- Type: application/pgp-signature, Size: 836 bytes --]

      parent reply	other threads:[~2013-08-07 13:55 UTC|newest]

Thread overview: 9+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-06-07  6:38 [PATCH] i2c: pxa: enable high speed mode for i2c bus Leilei Shang
     [not found] ` <1370587097-21006-1-git-send-email-shangll-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org>
2013-06-15 14:48   ` Wolfram Sang
2013-07-02  2:10     ` James Lebron
     [not found]       ` <CAOng1WTa0c2Jb9yPeynKXQ0K4-bPhrcGPsKd-AP-MuxQPH80Jg-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-05  1:53         ` James Lebron
     [not found]           ` <CAOng1WSNDQMrce6CSN9Zh-FHJgoC6+SbOioYTyuoiAFTBdPYbA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-11  8:00             ` James Lebron
     [not found]               ` <CAOng1WRu8yjVQ2jhm7fnPcG6ts+fBSxpn-D1ZCcLQvSVBfmF3A-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-22  6:39                 ` James Lebron
     [not found]                   ` <CAOng1WR+QVTZs9Zi=aKKsy_f=3R7=bB1PPWvuH2KtLaK+6rVBw-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-07-30  1:34                     ` James Lebron
     [not found]                       ` <CAOng1WTQP9XuPNDtiECZVOsCkowU1iyoq7C-h=Na7zspjFrjKA-JsoAwUIsXosN+BqQ9rBEUg@public.gmane.org>
2013-08-06  3:05                         ` James Lebron
2013-08-07 13:55         ` Wolfram Sang [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130807135538.GA2978@katana \
    --to=wsa-z923lk4zbo2bacvfa/9k2g@public.gmane.org \
    --cc=leileishangchina-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org \
    --cc=linux-i2c-u79uwXL29TY76Z2rM5mHXA@public.gmane.org \
    --cc=shangll-eYqpPyKDWXRBDgjK7y7TUQ@public.gmane.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body. 
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.