From: mturquette@linaro.org (Mike Turquette)
To: linux-arm-kernel@lists.infradead.org
Subject: [PATCH 2/3] mfd: sec: Add clock cell for s2mps11
Date: Wed, 07 Aug 2013 10:16:06 -0700 [thread overview]
Message-ID: <20130807171606.5348.76732@quantum> (raw)
In-Reply-To: <1373197462-4033-3-git-send-email-yadi.brar@samsung.com>
Quoting Yadwinder Singh Brar (2013-07-07 04:44:21)
> This patch adds clock to list of mfd cells for s2mps11 and DT documentation
> for clock part.
>
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
Reviewed-by: Mike Turquette <mturquette@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/s2mps11.txt | 20 ++++++++++++++++++++
> drivers/mfd/sec-core.c | 4 +++-
> 2 files changed, 23 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> index 36269c4..e41dd16 100644
> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> @@ -16,6 +16,21 @@ Optional properties:
> - interrupts: Interrupt specifiers for interrupt sources.
>
> Optional nodes:
> +- clocks: s2mps11 provides three(AP/CP/BT) buffered 32.768 KHz outputs, so to
> + register these as clocks with common clock framework instantiate a sub-node
> + named "clocks". It uses the common clock binding documented in :
> + [Documentation/devicetree/bindings/clock/clock-bindings.txt]
> + - #clock-cells: should be 1.
> +
> + - The following is the list of clocks generated by the controller. Each clock
> + is assigned an identifier and client nodes use this identifier to specify
> + the clock which they consume.
> + Clock ID
> + ----------------------
> + 32KhzAP 0
> + 32KhzCP 1
> + 32KhzBT 2
> +
> - regulators: The regulators of s2mps11 that have to be instantiated should be
> included in a sub-node named 'regulators'. Regulator nodes included in this
> sub-node should be of the format as listed below.
> @@ -55,6 +70,11 @@ Example:
> compatible = "samsung,s2mps11-pmic";
> reg = <0x66>;
>
> + s2m_osc: clocks{
> + #clock-cells = 1;
> + clock-output-names = "xx", "yy", "zz";
> + };
> +
> regulators {
> ldo1_reg: LDO1 {
> regulator-name = "VDD_ABB_3.3V";
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 760da8a..eaee5ec 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -58,7 +58,9 @@ static struct mfd_cell s5m8767_devs[] = {
> static struct mfd_cell s2mps11_devs[] = {
> {
> .name = "s2mps11-pmic",
> - },
> + }, {
> + .name = "s2mps11-clk",
> + }
> };
>
> #ifdef CONFIG_OF
> --
> 1.7.0.4
WARNING: multiple messages have this Message-ID (diff)
From: Mike Turquette <mturquette@linaro.org>
To: Yadwinder Singh Brar <yadi.brar@samsung.com>,
linux-kernel@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, sbkim73@samsung.com,
sameo@linux.intel.com, lee.jones@linaro.org, broonie@kernel.org,
yadi.brar01@gmail.com,
Yadwinder Singh Brar <yadi.brar@samsung.com>
Subject: Re: [PATCH 2/3] mfd: sec: Add clock cell for s2mps11
Date: Wed, 07 Aug 2013 10:16:06 -0700 [thread overview]
Message-ID: <20130807171606.5348.76732@quantum> (raw)
In-Reply-To: <1373197462-4033-3-git-send-email-yadi.brar@samsung.com>
Quoting Yadwinder Singh Brar (2013-07-07 04:44:21)
> This patch adds clock to list of mfd cells for s2mps11 and DT documentation
> for clock part.
>
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
Reviewed-by: Mike Turquette <mturquette@linaro.org>
> ---
> Documentation/devicetree/bindings/mfd/s2mps11.txt | 20 ++++++++++++++++++++
> drivers/mfd/sec-core.c | 4 +++-
> 2 files changed, 23 insertions(+), 1 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/mfd/s2mps11.txt b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> index 36269c4..e41dd16 100644
> --- a/Documentation/devicetree/bindings/mfd/s2mps11.txt
> +++ b/Documentation/devicetree/bindings/mfd/s2mps11.txt
> @@ -16,6 +16,21 @@ Optional properties:
> - interrupts: Interrupt specifiers for interrupt sources.
>
> Optional nodes:
> +- clocks: s2mps11 provides three(AP/CP/BT) buffered 32.768 KHz outputs, so to
> + register these as clocks with common clock framework instantiate a sub-node
> + named "clocks". It uses the common clock binding documented in :
> + [Documentation/devicetree/bindings/clock/clock-bindings.txt]
> + - #clock-cells: should be 1.
> +
> + - The following is the list of clocks generated by the controller. Each clock
> + is assigned an identifier and client nodes use this identifier to specify
> + the clock which they consume.
> + Clock ID
> + ----------------------
> + 32KhzAP 0
> + 32KhzCP 1
> + 32KhzBT 2
> +
> - regulators: The regulators of s2mps11 that have to be instantiated should be
> included in a sub-node named 'regulators'. Regulator nodes included in this
> sub-node should be of the format as listed below.
> @@ -55,6 +70,11 @@ Example:
> compatible = "samsung,s2mps11-pmic";
> reg = <0x66>;
>
> + s2m_osc: clocks{
> + #clock-cells = 1;
> + clock-output-names = "xx", "yy", "zz";
> + };
> +
> regulators {
> ldo1_reg: LDO1 {
> regulator-name = "VDD_ABB_3.3V";
> diff --git a/drivers/mfd/sec-core.c b/drivers/mfd/sec-core.c
> index 760da8a..eaee5ec 100644
> --- a/drivers/mfd/sec-core.c
> +++ b/drivers/mfd/sec-core.c
> @@ -58,7 +58,9 @@ static struct mfd_cell s5m8767_devs[] = {
> static struct mfd_cell s2mps11_devs[] = {
> {
> .name = "s2mps11-pmic",
> - },
> + }, {
> + .name = "s2mps11-clk",
> + }
> };
>
> #ifdef CONFIG_OF
> --
> 1.7.0.4
next prev parent reply other threads:[~2013-08-07 17:16 UTC|newest]
Thread overview: 25+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-07-07 11:44 [PATCH 0/3] Add clk driver to register s2mps11 clocks Yadwinder Singh Brar
2013-07-07 11:44 ` Yadwinder Singh Brar
2013-07-07 11:44 ` [PATCH 1/3] clk: s2mps11: Add support for s2mps11 Yadwinder Singh Brar
2013-07-07 11:44 ` Yadwinder Singh Brar
2013-07-26 15:43 ` Yadwinder Singh Brar
2013-07-26 15:43 ` Yadwinder Singh Brar
2013-08-05 23:23 ` Mike Turquette
2013-08-05 23:23 ` Mike Turquette
2013-08-06 4:25 ` Yadwinder Singh Brar
2013-08-06 4:25 ` Yadwinder Singh Brar
2013-08-06 19:52 ` Mike Turquette
2013-08-07 8:00 ` Lee Jones
2013-08-07 8:00 ` Lee Jones
2013-07-07 11:44 ` [PATCH 2/3] mfd: sec: Add clock cell " Yadwinder Singh Brar
2013-07-07 11:44 ` Yadwinder Singh Brar
2013-07-17 11:23 ` Lee Jones
2013-07-17 11:23 ` Lee Jones
2013-08-07 17:16 ` Mike Turquette [this message]
2013-08-07 17:16 ` Mike Turquette
2013-08-08 9:05 ` Lee Jones
2013-08-08 9:05 ` Lee Jones
2013-07-07 11:44 ` [PATCH 3/3] mfd: s2mps11: Remove clocks from regulators list Yadwinder Singh Brar
2013-07-07 11:44 ` Yadwinder Singh Brar
2013-07-17 11:27 ` Lee Jones
2013-07-17 11:27 ` Lee Jones
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807171606.5348.76732@quantum \
--to=mturquette@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.