From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from eggs.gnu.org ([2001:4830:134:3::10]:56107) by lists.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V77OB-0004qO-3W for qemu-devel@nongnu.org; Wed, 07 Aug 2013 13:19:16 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1V77O3-0001e3-8Y for qemu-devel@nongnu.org; Wed, 07 Aug 2013 13:19:10 -0400 Received: from mx1.redhat.com ([209.132.183.28]:2920) by eggs.gnu.org with esmtp (Exim 4.71) (envelope-from ) id 1V77O3-0001cS-1o for qemu-devel@nongnu.org; Wed, 07 Aug 2013 13:19:03 -0400 Received: from int-mx11.intmail.prod.int.phx2.redhat.com (int-mx11.intmail.prod.int.phx2.redhat.com [10.5.11.24]) by mx1.redhat.com (8.14.4/8.14.4) with ESMTP id r77HJ0FN017180 (version=TLSv1/SSLv3 cipher=DHE-RSA-AES256-SHA bits=256 verify=OK) for ; Wed, 7 Aug 2013 13:19:01 -0400 Date: Wed, 7 Aug 2013 13:18:57 -0400 From: Jeff Cody Message-ID: <20130807171857.GD22280@localhost.localdomain> References: <9e47d3ea77357b438ce2164f6e226d216553c58e.1375325971.git.jcody@redhat.com> <20130807152245.GC2929@dhcp-200-207.str.redhat.com> MIME-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Disposition: inline In-Reply-To: <20130807152245.GC2929@dhcp-200-207.str.redhat.com> Subject: Re: [Qemu-devel] [PATCH v2 4/9] block: vhdx - log support struct and defines List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , To: Kevin Wolf Cc: famz@redhat.com, qemu-devel@nongnu.org, stefanha@redhat.com On Wed, Aug 07, 2013 at 05:22:45PM +0200, Kevin Wolf wrote: > Am 01.08.2013 um 05:23 hat Jeff Cody geschrieben: > > This adds some magic number defines, and internal structure > > definitions for VHDX log replay support. > > > > Signed-off-by: Jeff Cody > > --- > > block/vhdx.h | 21 ++++++++++++++++++++- > > 1 file changed, 20 insertions(+), 1 deletion(-) > > > > diff --git a/block/vhdx.h b/block/vhdx.h > > index c8d8593..2db6615 100644 > > --- a/block/vhdx.h > > +++ b/block/vhdx.h > > @@ -151,7 +151,10 @@ typedef struct QEMU_PACKED VHDXRegionTableEntry { > > > > > > /* ---- LOG ENTRY STRUCTURES ---- */ > > +#define VHDX_LOG_MIN_SIZE (1024*1024) > > There should be spaces around the operator. > OK. Checkpatch.pl missed this, I guess it doesn't check macros? > Also, VHDX_LOG_ENTRY_MIN_SIZE? I thought at first that this was the > minimum size of the whole log (or does that happen to be the same and I > just missed it in the spec?) > This is indeed the minimum size for the entire log - once you get to patch 7, you'll see it used. But an interesting thing about this, is the original 0.95 spec said that 1MB was also the minimum log *entry* size as well. But that was incorrect, and the 1.00 spec notes that a log entry size min is 4KB (same as the log sector size). Jeff