From: Arnaldo Carvalho de Melo <acme@ghostprotocols.net>
To: Namhyung Kim <namhyung@kernel.org>
Cc: Peter Zijlstra <a.p.zijlstra@chello.nl>,
Paul Mackerras <paulus@samba.org>, Ingo Molnar <mingo@kernel.org>,
Namhyung Kim <namhyung.kim@lge.com>,
LKML <linux-kernel@vger.kernel.org>, Jiri Olsa <jolsa@redhat.com>,
Christoph Hellwig <hch@infradead.org>,
Pekka Enberg <penberg@kernel.org>,
Andi Kleen <andi@firstfloor.org>
Subject: Re: [PATCH/RFC 0/4] perf ui/gtk: Separate out GTK code to a shared object (v2)
Date: Wed, 7 Aug 2013 17:09:18 -0300 [thread overview]
Message-ID: <20130807200918.GF2665@ghostprotocols.net> (raw)
In-Reply-To: <1375766056-19377-1-git-send-email-namhyung@kernel.org>
Em Tue, Aug 06, 2013 at 02:14:12PM +0900, Namhyung Kim escreveu:
> Hi,
>
> This is v2 of gtk code separation patchset to reduce library
> dependencies of the perf executable.
>
> I only built libperf-gtk.so with -fPIC, and it's not linked to libperf
> at build time. All unresolved symbols used for perf should be
> resolved at runtime via perf executable (so libperf.a) - I didn't know
> that the linker permits unresolved symbols in a shared library at
> build time.
>
> Tested on my x86-64 machine only. It seems work well for me.
Not for me, please take a look at O= handling:
[acme@sandy linux]$ make -j8 O=/tmp/build/perf -C tools/perf/ install
<SNIP>
CHK gtk2
CHK -DHAVE_GTK_INFO_BAR
<SNIP>
make: Entering directory `/home/acme/git/linux/tools/perf'
make: *** No rule to make target `/tmp/build/perf/ui/gtk/browser.c',
needed by `/tmp/build/perf/ui/gtk/browser.o'. Stop.
make: *** Waiting for unfinished jobs....
make[1]: Entering directory `/home/acme/git/linux/tools/lib/traceevent'
make[2]: warning: jobserver unavailable: using -j1. Add `+' to parent
make rule.
make[1]: Entering directory `/home/acme/git/linux/tools/lib/lk'
AR liblk.a
make[1]: Leaving directory `/home/acme/git/linux/tools/lib/traceevent'
make[1]: Leaving directory `/home/acme/git/linux/tools/lib/lk'
make: Leaving directory `/home/acme/git/linux/tools/perf'
[acme@sandy linux]$
> The patch 1 is a bug fix and can be applied independently.
I took it, thanks.
prev parent reply other threads:[~2013-08-07 20:09 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-06 5:14 [PATCH/RFC 0/4] perf ui/gtk: Separate out GTK code to a shared object (v2) Namhyung Kim
2013-08-06 5:14 ` [PATCH 1/4] perf ui/gtk: Fix segmentation fault on perf_hpp__for_each_format loop Namhyung Kim
2013-08-06 5:56 ` Pekka Enberg
2013-08-12 10:23 ` [tip:perf/core] " tip-bot for Namhyung Kim
2013-08-06 5:14 ` [PATCH 2/4] perf tools: Separate out GTK codes to libperf-gtk.so Namhyung Kim
2013-08-06 5:56 ` Pekka Enberg
2013-08-06 5:14 ` [PATCH 3/4] perf tools: Setup GTK browser dynamically Namhyung Kim
2013-08-06 5:57 ` Pekka Enberg
2013-08-06 5:14 ` [PATCH 4/4] perf tools: Run dynamic loaded GTK browser Namhyung Kim
2013-08-06 5:58 ` Pekka Enberg
2013-08-07 20:09 ` Arnaldo Carvalho de Melo [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130807200918.GF2665@ghostprotocols.net \
--to=acme@ghostprotocols.net \
--cc=a.p.zijlstra@chello.nl \
--cc=andi@firstfloor.org \
--cc=hch@infradead.org \
--cc=jolsa@redhat.com \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=namhyung.kim@lge.com \
--cc=namhyung@kernel.org \
--cc=paulus@samba.org \
--cc=penberg@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.