From mboxrd@z Thu Jan 1 00:00:00 1970 From: Michael Trimarchi Subject: Re: [RFC PATCH] ASoC: omap-mcbsp: Add support for highter rate up to 384000 Date: Thu, 8 Aug 2013 13:04:10 +0200 Message-ID: <20130808110410.GA11288@panicking> References: <20130807182841.GA7823@panicking> <5203782D.1080008@ti.com> Mime-Version: 1.0 Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Return-path: Received: from mail-ee0-f44.google.com (mail-ee0-f44.google.com [74.125.83.44]) by alsa0.perex.cz (Postfix) with ESMTP id 500EC2619DC for ; Thu, 8 Aug 2013 13:04:34 +0200 (CEST) Received: by mail-ee0-f44.google.com with SMTP id b47so1432137eek.17 for ; Thu, 08 Aug 2013 04:04:32 -0700 (PDT) Content-Disposition: inline In-Reply-To: <5203782D.1080008@ti.com> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: alsa-devel-bounces@alsa-project.org Sender: alsa-devel-bounces@alsa-project.org To: Peter Ujfalusi Cc: alsa-devel@alsa-project.org, Mark Brown , Liam Girdwood , Jarkko Nikula List-Id: alsa-devel@alsa-project.org Hi On Thu, Aug 08, 2013 at 01:51:25PM +0300, Peter Ujfalusi wrote: > On 08/07/2013 09:28 PM, Michael Trimarchi wrote: > > Add support for highter rate up to 384000Khz. There are codecs in the > > market that can play up to this frequency. > > Test was done just with: > > = > > #define OMAP_MCBSP_RATES (SNDRV_PCM_RATE_8000_192000) > > = > > playing wav file 32bit/192000Khz stereo. Some glitch has observed > > but this should depend on the selected min buffer bytes that was > > left untouched in aplay and in the omap-pcm driver. > > = > > Signed-off-by: Michael Trimarchi > > --- > > sound/soc/omap/omap-mcbsp.c | 8 +++++++- > > 1 file changed, 7 insertions(+), 1 deletion(-) > > = > > diff --git a/sound/soc/omap/omap-mcbsp.c b/sound/soc/omap/omap-mcbsp.c > > index 7483efb..1e95f6a 100644 > > --- a/sound/soc/omap/omap-mcbsp.c > > +++ b/sound/soc/omap/omap-mcbsp.c > > @@ -39,7 +39,9 @@ > > #include "mcbsp.h" > > #include "omap-mcbsp.h" > > = > > -#define OMAP_MCBSP_RATES (SNDRV_PCM_RATE_8000_96000) > > +#define OMAP_MCBSP_RATES (SNDRV_PCM_RATE_8000_192000 | \ > = > I think only this change is enough for what you want to achieve. > = > > + SNDRV_PCM_RATE_CONTINUOUS | \ > > + SNDRV_PCM_RATE_KNOT) > = > The _KNOT is for sure not needed and I would not set the CONTINUOUS eithe= r. pcm5102pw is a codec that support 384000 rate so I think that PCM_RATE_KNOT is requested for such rate. Correct? > = > > = > > #define OMAP_MCBSP_SOC_SINGLE_S16_EXT(xname, xmin, xmax, \ > > xhandler_get, xhandler_put) \ > > @@ -574,11 +576,15 @@ static struct snd_soc_dai_driver omap_mcbsp_dai = =3D { > > .channels_max =3D 16, > > .rates =3D OMAP_MCBSP_RATES, > > .formats =3D SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE, > > + .rate_min =3D 8000, > > + .rate_max =3D 384000, > = > Why you want to limit the rates here? > = I didn't find in the market somenthing up to 384000. Michael > > }, > > .capture =3D { > > .channels_min =3D 1, > > .channels_max =3D 16, > > .rates =3D OMAP_MCBSP_RATES, > > + .rate_min =3D 8000, > > + .rate_max =3D 384000, > = > Same here, do not set these. > = > > .formats =3D SNDRV_PCM_FMTBIT_S16_LE | SNDRV_PCM_FMTBIT_S32_LE, > > }, > > .ops =3D &mcbsp_dai_ops, > > = > = > = > -- = > P=E9ter