From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from eggs.gnu.org ([2001:4830:134:3::10]:47482)
	by lists.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V7XWc-0006lD-Nz
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 17:13:39 -0400
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V7XWb-0003SL-T7
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 17:13:38 -0400
Received: from hall.aurel32.net ([2001:470:1f0b:4a8::1]:52015)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <aurelien@aurel32.net>) id 1V7XWb-0003SE-Ly
	for qemu-devel@nongnu.org; Thu, 08 Aug 2013 17:13:37 -0400
Date: Thu, 8 Aug 2013 23:13:33 +0200
From: Aurelien Jarno <aurelien@aurel32.net>
Message-ID: <20130808211333.GM4193@ohm.aurel32.net>
References: <1375787317-31359-1-git-send-email-aurelien@aurel32.net>
	<5200DF70.3070600@suse.de>
MIME-Version: 1.0
Content-Type: text/plain; charset=iso-8859-15
Content-Disposition: inline
Content-Transfer-Encoding: 8bit
In-Reply-To: <5200DF70.3070600@suse.de>
Subject: Re: [Qemu-devel] [PATCH v2 for-1.6] mips: revert commit
 b332d24a8e1290954029814d09156b06ede358e2
List-Id: <qemu-devel.nongnu.org>
List-Unsubscribe: <https://lists.nongnu.org/mailman/options/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <https://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Andreas =?iso-8859-15?Q?F=E4rber?= <afaerber@suse.de>
Cc: Anthony Liguori <aliguori@us.ibm.com>, qemu-devel@nongnu.org

On Tue, Aug 06, 2013 at 01:35:12PM +0200, Andreas Färber wrote:
> Am 06.08.2013 13:08, schrieb Aurelien Jarno:
> > Now that this code path is not triggered anymore during the tests,
> > revert commit b332d24a8e1290954029814d09156b06ede358e2. Booting a MIPS
> > target without kernel nor bios doesn't really make sense. At the same
> > time replace fprintf(stderr, ...) by error_report().
> > 
> > Signed-off-by: Aurelien Jarno <aurelien@aurel32.net>
> > ---
> >  hw/mips/mips_fulong2e.c |    4 +++-
> >  hw/mips/mips_jazz.c     |    5 +++--
> >  hw/mips/mips_malta.c    |    7 ++++---
> >  hw/mips/mips_mipssim.c  |    7 ++++---
> >  4 files changed, 14 insertions(+), 9 deletions(-)
> > 
> > v1 -> v2: replace fprintf(stderr, ...) by error_report()
> 
> If you drop the two remaining \n then feel free to commit with my
> Reviewed-by.
> 

Thanks for the review, I have just applied it with the mentioned
changes.


-- 
Aurelien Jarno                          GPG: 1024D/F1BCDB73
aurelien@aurel32.net                 http://www.aurel32.net