From: Theodore Ts'o <tytso@mit.edu>
To: Piotr Sarna <p.sarna@partner.samsung.com>
Cc: adilger.kernel@dilger.ca, linux-kernel@vger.kernel.org,
linux-ext4@vger.kernel.org, b.zolnierkie@samsung.com,
Kyungmin Park <kyungmin.park@samsung.com>
Subject: Re: [PATCH 2/2] ext4: improve mount/remount error handling
Date: Thu, 8 Aug 2013 23:03:50 -0400 [thread overview]
Message-ID: <20130809030350.GB1186@thunk.org> (raw)
In-Reply-To: <1375445027-25024-2-git-send-email-p.sarna@partner.samsung.com>
On Fri, Aug 02, 2013 at 02:03:47PM +0200, Piotr Sarna wrote:
> Commit 5688978 ("ext4: improve handling of conflicting mount options")
> introduced incorrect messages shown while choosing wrong mount options.
>
> Firstly, both cases of incorrect mount options, "data=journal,delalloc"
> and "data=journal,dioread_nolock" result in the same error message.
>
> Secondly, the problem above isn't solved for remount option: the mismatched
> parameter is simply ignored. Moreover, ext4_msg states that remount
> with options "data=journal,delalloc" succeeded, which is not true.
>
> To fix it up, I added a simple check after parse_options() call to ensure
> that data=journal and delalloc/dioread_nolock parameters are not present
> at the same time.
>
> Signed-off-by: Piotr Sarna <p.sarna@partner.samsung.com>
> Acked-by: Bartlomiej Zolnierkiewicz <b.zolnierkie@samsung.com>
> Signed-off-by: Kyungmin Park <kyungmin.park@samsung.com>
Applied, thanks.
- Ted
next prev parent reply other threads:[~2013-08-09 3:03 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-02 12:03 [PATCH 1/2] ext4: fix handling of nodelalloc parameter Piotr Sarna
2013-08-02 12:03 ` [PATCH 2/2] ext4: improve mount/remount error handling Piotr Sarna
2013-08-09 3:03 ` Theodore Ts'o [this message]
2013-08-04 1:36 ` [PATCH 1/2] ext4: fix handling of nodelalloc parameter Theodore Ts'o
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809030350.GB1186@thunk.org \
--to=tytso@mit.edu \
--cc=adilger.kernel@dilger.ca \
--cc=b.zolnierkie@samsung.com \
--cc=kyungmin.park@samsung.com \
--cc=linux-ext4@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.sarna@partner.samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.