From: Pablo Neira Ayuso <pablo@netfilter.org>
To: Arturo Borrero Gonzalez <arturo.borrero.glez@gmail.com>
Cc: Alvaro Neira <alvaroneay@gmail.com>,
Netfilter Development Mailing list
<netfilter-devel@vger.kernel.org>, Eric Leblond <eric@regit.org>
Subject: Re: [libnftables PATCH 11/13] expr: payload: add nft_str2base function
Date: Fri, 9 Aug 2013 13:43:47 +0200 [thread overview]
Message-ID: <20130809114347.GA21458@localhost> (raw)
In-Reply-To: <CAOkSjBhD94HpSmHmNLtpbeKrjygKu9zg5eeQHnWZ=LPrMBF=ZQ@mail.gmail.com>
On Fri, Aug 09, 2013 at 01:31:35PM +0200, Arturo Borrero Gonzalez wrote:
> > if (base_str == NULL)
> > return -1;
> >
> > - if (strcmp(base_str, "link") == 0)
> > - payload->base = NFT_PAYLOAD_LL_HEADER;
> > - else if (strcmp(base_str, "network") == 0)
> > - payload->base = NFT_PAYLOAD_NETWORK_HEADER;
> > - else if (strcmp(base_str, "transport") == 0)
> > - payload->base = NFT_PAYLOAD_TRANSPORT_HEADER;
> > - else
> > - goto err;
> > + base = nft_str2base(base_str);
> > +
> > + if (base < 0)
> > + return -1;
>
> I think we need this:
>
> payload->base = base;
Good catch, I'm going to manually fix this. Thanks for reviewing.
> Also, maybe goto err in case of base < 0
errno is already set from the new function.
next prev parent reply other threads:[~2013-08-09 11:43 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2013-08-09 11:11 [libnftables PATCH 01/13] src: expr: missing commas in json output support Alvaro Neira
2013-08-09 11:12 ` [libnftables PATCH 02/13] src: expr: missing curly braces " Alvaro Neira
2013-08-09 11:12 ` [libnftables PATCH 03/13] src: expr: change wrong value in data_reg Alvaro Neira
2013-08-09 11:12 ` [libnftables PATCH 04/13] src: fix display of compat_flag and compat_proto Alvaro Neira
2013-08-09 11:12 ` [libnftables PATCH 05/13] expr: ct: optional output in ct Alvaro Neira
2013-08-09 11:13 ` [libnftables PATCH 06/13] json: bitwise: add missing node len Alvaro Neira
2013-08-09 11:13 ` [libnftables PATCH 07/13] src: json: delete unneeded JSON prefixes Alvaro Neira
2013-08-09 11:13 ` [libnftables PATCH 08/13] expr: bytecode: add nft_str2ntoh function Alvaro Neira
2013-08-09 11:13 ` [libnftables PATCH 09/13] expr: cmp: add nft_str2cmp function Alvaro Neira
2013-08-09 11:13 ` [libnftables PATCH 10/13] expr: nat: add nft_str2nat function Alvaro Neira
2013-08-09 11:14 ` [libnftables PATCH 11/13] expr: payload: add nft_str2base function Alvaro Neira
2013-08-09 11:31 ` Arturo Borrero Gonzalez
2013-08-09 11:43 ` Pablo Neira Ayuso [this message]
2013-08-09 11:34 ` Arturo Borrero Gonzalez
2013-08-09 11:14 ` [libnftables PATCH 12/13] example: nft-rule-get: family parameter added Alvaro Neira
2013-08-09 11:14 ` [libnftables PATCH 13/13] jansson: Add nft_jansson_family function Alvaro Neira
2013-08-09 11:44 ` [libnftables PATCH 01/13] src: expr: missing commas in json output support Pablo Neira Ayuso
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=20130809114347.GA21458@localhost \
--to=pablo@netfilter.org \
--cc=alvaroneay@gmail.com \
--cc=arturo.borrero.glez@gmail.com \
--cc=eric@regit.org \
--cc=netfilter-devel@vger.kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.