All of lore.kernel.org
 help / color / mirror / Atom feed
From: Denys Dmytriyenko <denys@ti.com>
To: Ian Geiser <igeiser@devonit.com>
Cc: "meta-ti@yoctoproject.org" <meta-ti@yoctoproject.org>
Subject: Re: [PATCH 1/2] Fix filespath for dylan
Date: Mon, 12 Aug 2013 00:10:47 -0400	[thread overview]
Message-ID: <20130812041047.GC29743@edge> (raw)
In-Reply-To: <B57A220D1EE1644685BA9AD5C790D20526BEAAD744@SOUTHSIDE.devonintlgroup.com>

On Mon, Aug 12, 2013 at 12:03:38AM -0400, Ian Geiser wrote:
> I can fix and resubmit. I found it while porting our 8148 build to Dylan. 
> Thanks!

Actually, never mind, I think I'm wrong on this one - looks like I'm not 
thinking straight at this late hour... :)


> > -----Original Message-----
> > From: Denys Dmytriyenko [mailto:denys@ti.com]
> > Sent: Sunday, August 11, 2013 11:30 PM
> > To: Ian Geiser
> > Cc: meta-ti@yoctoproject.org
> > Subject: Re: [meta-ti] [PATCH 1/2] Fix filespath for dylan
> > 
> > On Sun, Aug 11, 2013 at 07:41:34PM -0400, igeiser@devonit.com wrote:
> > > From: Ian Reinhart Geiser <igeiser@devonit.com>
> > >
> > > The old way of setting THISDIR in a bbappend clobbers THISDIR for
> > > other layers.  This change makes it use the new way that is done in
> > > dylan.
> > 
> > Thanks! I've been meaning to fix those for quite some time, but there
> > was always something more important... :)
> > 
> > 
> > > Signed-off-by: Ian Reinhart Geiser <igeiser@devonit.com>
> > > ---
> > >  recipes-bsp/formfactor/formfactor_0.0.bbappend |    5 ++---
> > >  1 file changed, 2 insertions(+), 3 deletions(-)
> > >
> > > diff --git a/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > b/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > > index 4b8d0e6..491d403 100644
> > > --- a/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > > +++ b/recipes-bsp/formfactor/formfactor_0.0.bbappend
> > > @@ -1,3 +1,2 @@
> > > -THISDIR := "${@os.path.dirname(bb.data.getVar('FILE', d, True))}"
> > > -FILESPATH =. "${@base_set_filespath(["${THISDIR}/${PN}"], d)}:"
> > > -
> > > +PRINC := "${@int(PRINC) + 1}"
> > > +FILESEXTRAPATHS_prepend := "${THISDIR}/${PN}:"
> > 
> > The above should be _append since that is what =. operand does and also
> > since
> > the colon is at the end.
> > 
> > --
> > Denys
> 


  reply	other threads:[~2013-08-12  4:10 UTC|newest]

Thread overview: 7+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2013-08-11 23:41 [PATCH 1/2] Fix filespath for dylan igeiser
2013-08-11 23:41 ` [PATCH 2/2] " igeiser
2013-08-12  3:30   ` Denys Dmytriyenko
2013-08-12  3:30 ` [PATCH 1/2] " Denys Dmytriyenko
2013-08-12  4:03   ` Ian Geiser
2013-08-12  4:10     ` Denys Dmytriyenko [this message]
2013-08-12  4:51       ` Ian Geiser

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=20130812041047.GC29743@edge \
    --to=denys@ti.com \
    --cc=igeiser@devonit.com \
    --cc=meta-ti@yoctoproject.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.